Re: [PATCH v3 3/4] dts: add per-test-suite configuration

2024-11-19 Thread Luca Vizzarro
On 19/11/2024 16:31, Dean Marx wrote: So... this is a weird one. I've integrated the code generation under dts-check-format.sh, so nobody should really worry about it, as that should be run before submitting. If it's not, then the CI will eventually pick it up when dts-check-format will be in pla

Re: [PATCH v3 3/4] dts: add per-test-suite configuration

2024-11-19 Thread Dean Marx
> So... this is a weird one. I've integrated the code generation under > dts-check-format.sh, so nobody should really worry about it, as that > should be run before submitting. If it's not, then the CI will > eventually pick it up when dts-check-format will be in place. Right, and that definitely

Re: [PATCH v3 3/4] dts: add per-test-suite configuration

2024-11-14 Thread Luca Vizzarro
Hi Dean! Thank you for your review! On 13/11/2024 21:44, Dean Marx wrote: I like the idea of mapping the suite to specific test cases, and for the most part the custom configuration option as well. The only thing that I feel should be different is the way the code generation is documented, I th

Re: [PATCH v3 3/4] dts: add per-test-suite configuration

2024-11-13 Thread Dean Marx
> > > On Fri, Nov 8, 2024 at 8:38 AM Luca Vizzarro > wrote: > >> Allow test suites to be configured individually. Moreover enable them to >> implement their own custom configuration. >> >> This solution adds some new complexity to DTS, which is generated source >> code. In order to ensure strong t

[PATCH v3 3/4] dts: add per-test-suite configuration

2024-11-08 Thread Luca Vizzarro
Allow test suites to be configured individually. Moreover enable them to implement their own custom configuration. This solution adds some new complexity to DTS, which is generated source code. In order to ensure strong typing, the test suites and their custom configurations need to be linked in t