Re: [PATCH v3 10/11] telemetry: disable json print formatting with msvc

2023-04-06 Thread Tyler Retzlaff
On Thu, Apr 06, 2023 at 10:25:07AM +0100, Bruce Richardson wrote: > On Wed, Apr 05, 2023 at 05:45:18PM -0700, Tyler Retzlaff wrote: > > VLAs are unsafe and will never be implemented in MSVC. When compiling > > with MSVC just return immediately indicating 0 output characters > > formatted. > > > >

Re: [PATCH v3 10/11] telemetry: disable json print formatting with msvc

2023-04-06 Thread Bruce Richardson
On Wed, Apr 05, 2023 at 05:45:18PM -0700, Tyler Retzlaff wrote: > VLAs are unsafe and will never be implemented in MSVC. When compiling > with MSVC just return immediately indicating 0 output characters > formatted. > > For now telemetry doesn't work on Windows, we will revisit support for > the t

[PATCH v3 10/11] telemetry: disable json print formatting with msvc

2023-04-05 Thread Tyler Retzlaff
VLAs are unsafe and will never be implemented in MSVC. When compiling with MSVC just return immediately indicating 0 output characters formatted. For now telemetry doesn't work on Windows, we will revisit support for the telemetry library sometime after we establish the DPDK unit tests. Signed-of