RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-05-01 Thread Akhil Goyal
> > > > + > > > > +void * > > > > +rte_cryptodev_session_event_mdata_get(struct rte_crypto_op *op) { > > > Null check for op? > > > > Null check can be added, but this a datapath dpdk internal API. > > We do not normally add checks in datapath. > > If you insist, I can add, but before calling this

RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-05-01 Thread Gujjar, Abhinandan S
> -Original Message- > From: Akhil Goyal > Sent: Friday, April 29, 2022 5:47 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Jayatheerthan, Jay ; > Vangati, Narender ; Volodymyr Fialko > > Subject: RE: [PATCH

RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-04-29 Thread Akhil Goyal
Hi Abhinandan, Please see inline. > > + > > +void * > > +rte_cryptodev_session_event_mdata_get(struct rte_crypto_op *op) { > Null check for op? Null check can be added, but this a datapath dpdk internal API. We do not normally add checks in datapath. If you insist, I can add, but before calling t

RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-04-28 Thread Gujjar, Abhinandan S
; > Subject: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata > > From: Volodymyr Fialko > > Currently, crypto session userdata is used to set event crypto metadata from > the application and the driver is dereferencing it in driver which is not > correct. > User dat

RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-04-27 Thread Zhang, Roy Fan
ject: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata > > From: Volodymyr Fialko > > Currently, crypto session userdata is used to set event crypto > metadata from the application and the driver is dereferencing it > in driver which is not correct. User data is meant

[PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-04-21 Thread Akhil Goyal
From: Volodymyr Fialko Currently, crypto session userdata is used to set event crypto metadata from the application and the driver is dereferencing it in driver which is not correct. User data is meant to be opaque to the driver. To support this, new API is added to get and set event crypto metad