Re: [PATCH v3 00/16] stop using variadic argument pack extension

2024-02-29 Thread David Marchand
On Wed, Feb 28, 2024 at 6:59 PM Tyler Retzlaff wrote: > > I find this new helper less tricky to use and easier to read than the > > RTE_FMT_* stuff that gets copy/pasted everywhere. > > The changes are quite mechanical, so even though we are past -rc1, +1 > > for me on the series. > > > > Can we f

Re: [PATCH v3 00/16] stop using variadic argument pack extension

2024-02-28 Thread Tyler Retzlaff
On Wed, Feb 28, 2024 at 06:29:14PM +0100, David Marchand wrote: > On Mon, Feb 26, 2024 at 9:20 PM Tyler Retzlaff > wrote: > > > > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > > without the user of RTE_LOG_LINE using the args... and ## args compiler > > extension to conditi

Re: [PATCH v3 00/16] stop using variadic argument pack extension

2024-02-28 Thread David Marchand
On Mon, Feb 26, 2024 at 9:20 PM Tyler Retzlaff wrote: > > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > without the user of RTE_LOG_LINE using the args... and ## args compiler > extension to conditionally remove trailing comma when the macro receives > only a single argumen

Re: [PATCH v3 00/16] stop using variadic argument pack extension

2024-02-28 Thread Tyler Retzlaff
On Wed, Feb 28, 2024 at 12:45:04PM +0100, David Marchand wrote: > On Tue, Feb 27, 2024 at 7:15 PM Tyler Retzlaff > wrote: > > > > On Mon, Feb 26, 2024 at 12:54:36PM -0800, Stephen Hemminger wrote: > > > On Mon, 26 Feb 2024 12:19:30 -0800 > > > Tyler Retzlaff wrote: > > > > > > > RTE_LOG_LINE cann

Re: [PATCH v3 00/16] stop using variadic argument pack extension

2024-02-28 Thread David Marchand
On Tue, Feb 27, 2024 at 7:15 PM Tyler Retzlaff wrote: > > On Mon, Feb 26, 2024 at 12:54:36PM -0800, Stephen Hemminger wrote: > > On Mon, 26 Feb 2024 12:19:30 -0800 > > Tyler Retzlaff wrote: > > > > > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > > > without the user of RTE

Re: [PATCH v3 00/16] stop using variadic argument pack extension

2024-02-27 Thread Tyler Retzlaff
On Mon, Feb 26, 2024 at 12:54:36PM -0800, Stephen Hemminger wrote: > On Mon, 26 Feb 2024 12:19:30 -0800 > Tyler Retzlaff wrote: > > > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > > without the user of RTE_LOG_LINE using the args... and ## args compiler > > extension to co

Re: [PATCH v3 00/16] stop using variadic argument pack extension

2024-02-26 Thread Stephen Hemminger
On Mon, 26 Feb 2024 12:19:30 -0800 Tyler Retzlaff wrote: > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > without the user of RTE_LOG_LINE using the args... and ## args compiler > extension to conditionally remove trailing comma when the macro receives > only a single argum

[PATCH v3 00/16] stop using variadic argument pack extension

2024-02-26 Thread Tyler Retzlaff
RTE_LOG_LINE cannot be augmented with a prefix format and arguments without the user of RTE_LOG_LINE using the args... and ## args compiler extension to conditionally remove trailing comma when the macro receives only a single argument. Provide a new/similar macro RTE_LOG_LINE_PREFIX that accepts