Re: [PATCH v3] vhost: enhance virtqueue access lock asserts

2024-02-26 Thread Stephen Hemminger
On Mon, 26 Feb 2024 20:40:57 +0100 Maxime Coquelin wrote: > > + > > +/* vhost_user_msg_handler() locks all qps based on a handler's > > lock_all_qps. > > + * Later, a handler may need to ensure the vq has been locked (for example, > > + * when calling lock annotated helpers). > > + * > > + * Not

Re: [PATCH v3] vhost: enhance virtqueue access lock asserts

2024-02-26 Thread Maxime Coquelin
On 2/26/24 18:05, David Marchand wrote: A simple comment in vhost_user_msg_handler() is not that robust. Add a lock_all_qps property to message handlers so that their implementation can add a build check and assert a vq is locked. Signed-off-by: David Marchand --- Changes since v2: - droppe

[PATCH v3] vhost: enhance virtqueue access lock asserts

2024-02-26 Thread David Marchand
A simple comment in vhost_user_msg_handler() is not that robust. Add a lock_all_qps property to message handlers so that their implementation can add a build check and assert a vq is locked. Signed-off-by: David Marchand --- Changes since v2: - dropped review tags, - following use of static_asse