RE: [PATCH v3] lib/eal: fix segfaults due to thread exit order

2022-06-07 Thread Zeng, ZhichaoX
r-all' parameter, there will be no exception. But I don't know the software environment for automated testing, so I can't verify this statement. Regards > Subject: [PATCH v3] lib/eal: fix segfaults due to thread exit order > From: Zhichao Zeng > The eal-intr-thread is not

RE: [PATCH v3] lib/eal: fix segfaults due to thread exit order

2022-06-02 Thread Zeng, ZhichaoX
Olivier > > ; > tho...@monjalon.net; sta...@dpdk.org > Subject: Re: [PATCH v3] lib/eal: fix segfaults due to thread exit order > > On Mon, 30 May 2022 13:47:38 + > zhichaox.z...@intel.com wrote: > > @@ -883,6 +896,8 @@ rte_eal_init(int argc, char **argv) > > > >

Re: [PATCH v3] lib/eal: fix segfaults due to thread exit order

2022-05-30 Thread Stephen Hemminger
On Mon, 30 May 2022 13:47:38 + zhichaox.z...@intel.com wrote: > @@ -883,6 +896,8 @@ rte_eal_init(int argc, char **argv) > > eal_mcfg_complete(); > > + pthread_atfork(NULL, warn_parent, scratch_child); > + > return fctret; > } There are lots of other cases where DPDK will

Re: [PATCH v3] lib/eal: fix segfaults due to thread exit order

2022-05-30 Thread Stephen Hemminger
On Mon, 30 May 2022 13:47:38 + zhichaox.z...@intel.com wrote: > +static void warn_parent(void) > +{ > + RTE_LOG(WARNING, EAL, "fork() was called, DPDK won't work in the child " > + "process unless it calls rte_eal_init()\n"); > +} > + Too wordy. Don't break messages across lin

[PATCH v3] lib/eal: fix segfaults due to thread exit order

2022-05-29 Thread zhichaox . zeng
From: Zhichao Zeng The eal-intr-thread is not closed before memory cleanup in the process of exiting. There is a small probability that when the eal-intr-thread is about to use some pointers, the memory were just cleaned, which cause the segment fault error caught by ASan. This patch close the e