Re: [EXT] Re: [PATCH v3] app/mldev: add internal function for file read

2023-05-03 Thread Tyler Retzlaff
On Wed, May 03, 2023 at 11:28:26AM -0700, Stephen Hemminger wrote: > On Wed, 3 May 2023 14:59:40 + > Srikanth Yalavarthi wrote: > > > > > > > Granted this is a test program. But why did you ignore my feedback that > > > this > > > is the slowest way to read a file. Stdio requires extra buff

Re: [EXT] Re: [PATCH v3] app/mldev: add internal function for file read

2023-05-03 Thread Stephen Hemminger
On Wed, 3 May 2023 14:59:40 + Srikanth Yalavarthi wrote: > > > > Granted this is a test program. But why did you ignore my feedback that this > > is the slowest way to read a file. Stdio requires extra buffering, use > > regular > > read() or better yet mmap(). > > Agree on the improveme

RE: [EXT] Re: [PATCH v3] app/mldev: add internal function for file read

2023-05-03 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 03 May 2023 20:24 > To: Srikanth Yalavarthi > Cc: Anup Prabhu ; dev@dpdk.org; Shivah Shankar > Shankar Narayan Rao ; Prince Takkar > > Subject: [EXT] Re: [PATCH v3] app/mldev: add internal function for file

Re: [PATCH v3] app/mldev: add internal function for file read

2023-05-03 Thread Stephen Hemminger
On Wed, 3 May 2023 01:56:41 -0700 Srikanth Yalavarthi wrote: > Added internal function to read model, input and reference > files with required error checks. This change fixes the > unchecked return value and improper use of negative value > issues reported by coverity scan for file read operatio

[PATCH v3] app/mldev: add internal function for file read

2023-05-03 Thread Srikanth Yalavarthi
Added internal function to read model, input and reference files with required error checks. This change fixes the unchecked return value and improper use of negative value issues reported by coverity scan for file read operations. Coverity issue: 383742, 383743 Fixes: f6661e6d9a3a ("app/mldev: va