Re: [PATCH v26 00/15] Log subsystem improvements

2024-10-20 Thread Baruch Even
Hi, I'm not sure about the proper way to do a code review here, feel free to educate me if there is a better way to do it. I couldn't find the actual patches text in the mail and patchwork has no interface to write comments on the line itself but I may very well have missed something. https://pat

Re: [PATCH v26 00/15] Log subsystem improvements

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 19:07:18 +0200 David Marchand wrote: > Hello Stephen, > > On Wed, Oct 16, 2024 at 10:24 PM Stephen Hemminger > wrote: > > > > Improvements and unification of logging library. > > This version works on all platforms: Linux, Windows and FreeBSD. > > > > This is update to rewor

Re: [PATCH v26 00/15] Log subsystem improvements

2024-10-18 Thread David Marchand
Hello Stephen, On Wed, Oct 16, 2024 at 10:24 PM Stephen Hemminger wrote: > > Improvements and unification of logging library. > This version works on all platforms: Linux, Windows and FreeBSD. > > This is update to rework patch set. It adds several new features > to the console log output. > >

[PATCH v26 00/15] Log subsystem improvements

2024-10-16 Thread Stephen Hemminger
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of