Re: [PATCH v2 7/7] dts: enable shell pooling

2025-04-25 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Fri, Mar 14, 2025 at 9:19 AM Luca Vizzarro wrote: > > Enable the ShellPool class to be used in the test run, and let > InteractiveShells register themselves to the pool upon shell startup. > Moreover, to avoid the ShellPool to call InteractiveShell.close more > th

Re: [PATCH v2 7/7] dts: enable shell pooling

2025-04-24 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v2 7/7] dts: enable shell pooling

2025-04-24 Thread Dean Marx
Hi Luca, I've read through each patch and it looks good to me, but I did run into some issues applying the series on my end. It seems like the rebase messed something up with git, might need to do another version with a new rebase. Otherwise, Reviewed-by: Dean Marx

[PATCH v2 7/7] dts: enable shell pooling

2025-03-14 Thread Luca Vizzarro
Enable the ShellPool class to be used in the test run, and let InteractiveShells register themselves to the pool upon shell startup. Moreover, to avoid the ShellPool to call InteractiveShell.close more than once if the shell was not unregistered correctly, add a way to prevent the method to be call