RE: [PATCH v2 4/8] net/rnp: add mbx basic api feature

;+struct rnp_mbx_stats { >... >+} Regards Wenbo -Original Message- From: Stephen Hemminger Sent: 2023年8月3日 0:12 To: Wenbo Cao Cc: dev@dpdk.org; ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru Subject: Re: [PATCH v2 4/8] net/rnp: add mbx basic api feature On Wed, 2 Aug 2023

Re: [PATCH v2 4/8] net/rnp: add mbx basic api feature

On Wed, 2 Aug 2023 08:11:02 + Wenbo Cao wrote: > +struct rnp_mbx_stats { > + u32 msgs_tx; > + u32 msgs_rx; > + > + u32 acks; > + u32 reqs; > + u32 rsts; > +}; Easy to cause wraparound of 32 bits in these stats. Why use u32 and not uint32_t or uint64_t. > +struct rnp_mbx

[PATCH v2 4/8] net/rnp: add mbx basic api feature

mbx base code is for communicate with the firmware Signed-off-by: Wenbo Cao Suggested-by: Stephen Hemminger --- drivers/net/rnp/base/rnp_hw.h | 107 ++- drivers/net/rnp/meson.build | 1 + drivers/net/rnp/rnp.h | 35 +++ drivers/net/rnp/rnp_ethdev.c | 70 - drivers/net/rnp