RE: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

2025-06-23 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, 23 June 2025 14.08 > > On Mon, Jun 23, 2025 at 10:53 AM Marat Khalili > wrote: > > > > We cannot just remove __rte_cache_aligned from rte_graph_cluster_stats > without removing it from rte_graph_cluster_node_stats because o

RE: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

2025-06-23 Thread Marat Khalili
> -Original Message- > From: David Marchand > Sent: Monday 23 June 2025 13:08 > > Could you spend some time on reviewing patches on the topic? > Like for example: > https://patchwork.dpdk.org/project/dpdk/list/?series=35509 Sure, will look! > rte_malloc is not required. > I have a fix i

Re: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

2025-06-23 Thread David Marchand
On Mon, Jun 23, 2025 at 10:53 AM Marat Khalili wrote: > > Gently reminding about this issue, I still hope to see graph tests passing > under sanitizer. Thanks for trying to fix this, but without coverage on the topic, it is likely we will have new errors in the future. Now that the trace framew

RE: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

2025-06-23 Thread Marat Khalili
v@dpdk.org > Subject: RE: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday 17 June 2025 16:50 > > > > > > > -struct __rte_cache_aligned rte_grap

RE: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

2025-06-17 Thread Marat Khalili
> -Original Message- > From: Jerin Jacob > Sent: Tuesday 17 June 2025 16:50 > > > > > -struct __rte_cache_aligned rte_graph_cluster_node_stats { > > > > +struct rte_graph_cluster_node_stats { > > > > > > This is a fastpath structure. No need to change the alignment here. > > > > rte_graph

Re: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

2025-06-17 Thread Jerin Jacob
On Tue, Jun 17, 2025 at 9:11 PM Marat Khalili wrote: > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday 17 June 2025 16:28 > > > > > -struct __rte_cache_aligned rte_graph_cluster_node_stats { > > > +struct rte_graph_cluster_node_stats { > > > > This is a fastpath structure.

RE: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

2025-06-17 Thread Marat Khalili
> -Original Message- > From: Jerin Jacob > Sent: Tuesday 17 June 2025 16:28 > > > -struct __rte_cache_aligned rte_graph_cluster_node_stats { > > +struct rte_graph_cluster_node_stats { > > This is a fastpath structure. No need to change the alignment here. rte_graph_cluster_stats include

Re: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

2025-06-17 Thread Jerin Jacob
On Tue, Jun 17, 2025 at 8:44 PM Marat Khalili wrote: > > This was flagged by undefined behaviour sanitizer: struct > rte_graph_cluster_stats is declared as `__rte_cache_aligned` but was > allocated using stdlib realloc which caused misaligned allocation. More > than one test needs to be executed i

[PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

2025-06-17 Thread Marat Khalili
This was flagged by undefined behaviour sanitizer: struct rte_graph_cluster_stats is declared as `__rte_cache_aligned` but was allocated using stdlib realloc which caused misaligned allocation. More than one test needs to be executed in series in order to reproduce the problem using graph_autotest,