Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

2024-08-20 Thread Burakov, Anatoly
On 8/20/2024 11:45 AM, Robin Jarry wrote: Burakov, Anatoly, Aug 20, 2024 at 11:31: > I checked and unless I missed something, dpdk-pmdinfo.py uses the > symbols from the typing module for annotations. Not builtin container > types. It does both. Check e.g. line 147: def scrub_pci_ids(info: d

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

2024-08-20 Thread Robin Jarry
Burakov, Anatoly, Aug 20, 2024 at 11:31: > I checked and unless I missed something, dpdk-pmdinfo.py uses the > symbols from the typing module for annotations. Not builtin container > types. It does both. Check e.g. line 147: def scrub_pci_ids(info: dict): Ah, that does not require python 3.

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

2024-08-20 Thread Burakov, Anatoly
On 8/20/2024 11:20 AM, Robin Jarry wrote: Burakov, Anatoly, Aug 20, 2024 at 11:12: > FYI: if we change the minimum supported python version to 3.9, we could > even get rid of this import completely as builtin types `set`, `list`, > `tuple` and `dict` have become subscriptable. > >     https://

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

2024-08-20 Thread Robin Jarry
Burakov, Anatoly, Aug 20, 2024 at 11:12: > FYI: if we change the minimum supported python version to 3.9, we could > even get rid of this import completely as builtin types `set`, `list`, > `tuple` and `dict` have become subscriptable. > >    https://peps.python.org/pep-0585/ > > You can use

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

2024-08-20 Thread Burakov, Anatoly
On 8/19/2024 1:11 PM, Robin Jarry wrote: Anatoly Burakov, Aug 16, 2024 at 14:16: Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable Signed-off-by

Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style

2024-08-19 Thread Robin Jarry
Anatoly Burakov, Aug 16, 2024 at 14:16: Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable Signed-off-by: Anatoly Burakov --- usertools/cpu_layo

[PATCH v2 1/4] usertools/cpu_layout: update coding style

2024-08-16 Thread Anatoly Burakov
Update coding style: - make it PEP-484 compliant - address all flake8, mypy etc. warnings - use f-strings in place of old-style string interpolation - refactor printing to make the code more readable Signed-off-by: Anatoly Burakov --- usertools/cpu_layout.py | 162 ++