Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests

2023-10-03 Thread Stephen Hemminger
On Tue, 3 Oct 2023 17:50:13 +0100 Ferruh Yigit wrote: > On 10/3/2023 5:36 PM, Stephen Hemminger wrote: > > On Tue, 3 Oct 2023 11:47:51 +0100 > > Ferruh Yigit wrote: > > > >> On 10/2/2023 7:37 PM, Stephen Hemminger wrote: > >>> Some of the ethernet address formats which were invalid will > >

Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests

2023-10-03 Thread Ferruh Yigit
On 10/3/2023 5:36 PM, Stephen Hemminger wrote: > On Tue, 3 Oct 2023 11:47:51 +0100 > Ferruh Yigit wrote: > >> On 10/2/2023 7:37 PM, Stephen Hemminger wrote: >>> Some of the ethernet address formats which were invalid will >>> now become valid inputs when rte_ether_unformat_addr is modified >>> to

Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests

2023-10-03 Thread Stephen Hemminger
On Tue, 3 Oct 2023 11:59:04 +0100 Ferruh Yigit wrote: > Ah, I guess it is taken as "::" format, but number of digit > is not enforced, so "1:2:3" is a valid format, should we add this to API > documentation as example format? Or is this unintended side effect? By allowing leading zer

Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests

2023-10-03 Thread Stephen Hemminger
On Tue, 3 Oct 2023 11:47:51 +0100 Ferruh Yigit wrote: > On 10/2/2023 7:37 PM, Stephen Hemminger wrote: > > Some of the ethernet address formats which were invalid will > > now become valid inputs when rte_ether_unformat_addr is modified > > to allow leading zeros. > > > > Also, make local variab

Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests

2023-10-03 Thread Ferruh Yigit
On 10/3/2023 11:47 AM, Ferruh Yigit wrote: > On 10/2/2023 7:37 PM, Stephen Hemminger wrote: >> Some of the ethernet address formats which were invalid will >> now become valid inputs when rte_ether_unformat_addr is modified >> to allow leading zeros. >> >> Also, make local variables static. >> >> S

Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests

2023-10-03 Thread Ferruh Yigit
On 10/2/2023 7:37 PM, Stephen Hemminger wrote: > Some of the ethernet address formats which were invalid will > now become valid inputs when rte_ether_unformat_addr is modified > to allow leading zeros. > > Also, make local variables static. > > Signed-off-by: Stephen Hemminger > <...> > @@ -

[PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests

2023-10-02 Thread Stephen Hemminger
Some of the ethernet address formats which were invalid will now become valid inputs when rte_ether_unformat_addr is modified to allow leading zeros. Also, make local variables static. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_etheraddr.c | 11 --- 1 file changed, 4 ins