RE: [EXTERNAL] Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-07-28 Thread Sunil Kumar Kori
Azrad ; Long Li ; Wei Hu ; Chaoyong He ; Jiawen Wu ; Andrew Rybchenko ; Jerin Jacob ; Maciej Czekaj [C] ; Jian Wang ; Maxime Coquelin ; Chenbo Xia ; Jochen Behrens ; Thomas Monjalon ; Ferruh Yigit ; dev@dpdk.org Subject: [EXTERNAL] Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-07-28 Thread Stephen Hemminger
On Mon, 12 May 2025 20:37:19 +0530 wrote: > From: Sunil Kumar Kori > > As rte_eth_rx_queue_count() returns signed value to represent > the error cases but internally invoked callback is returning > unsigned value. Hence unnecessary type conversion is done. > > To avoid this typecasting from si

Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-07-26 Thread Andrew Rybchenko
On 5/12/25 19:04, Morten Brørup wrote: From: Sunil Kumar Kori Sent: Monday, 12 May 2025 17.07 As rte_eth_rx_queue_count() returns signed value to represent the error cases but internally invoked callback is returning unsigned value. Hence unnecessary type conversion is done. To avoid this type

RE: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-28 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 28 May 2025 11.14 > > > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > > Sent: Wednesday, 28 May 2025 10.24 > > > > > > > > > > > > > > From: Stephen Hemminger [mailto:step...@networkplu

RE: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-28 Thread Konstantin Ananyev
> > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Wednesday, 28 May 2025 10.24 > > > > > > > > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > > > Sent: Tuesday, 27 May 2025 17.07 > > > > > > > > > > On Mon, 12 May 2025 20:37:19 +0530 > > >

RE: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-28 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 28 May 2025 10.24 > > > > > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > > Sent: Tuesday, 27 May 2025 17.07 > > > > > > > > On Mon, 12 May 2025 20:37:19 +0530 > > > > wrote: > > > > > >

RE: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-28 Thread Konstantin Ananyev
> > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Tuesday, 27 May 2025 17.07 > > > > On Mon, 12 May 2025 20:37:19 +0530 > > wrote: > > > > > /**@{@name Rx hardware descriptor states > > > diff --git a/lib/ethdev/rte_ethdev_core.h > > b/lib/ethdev/rte_ethdev_core.h >

RE: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-28 Thread Konstantin Ananyev
> > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Tuesday, 27 May 2025 17.07 > > > > > > On Mon, 12 May 2025 20:37:19 +0530 > > > wrote: > > > > > > > /**@{@name Rx hardware descriptor states > > > > diff --git a/lib/ethdev/rte_ethdev_core.h > > > b/lib/ethdev/r

RE: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-27 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 27 May 2025 17.07 > > On Mon, 12 May 2025 20:37:19 +0530 > wrote: > > > /**@{@name Rx hardware descriptor states > > diff --git a/lib/ethdev/rte_ethdev_core.h > b/lib/ethdev/rte_ethdev_core.h > > index e55fb42996..4f

Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-27 Thread Stephen Hemminger
On Mon, 12 May 2025 20:37:19 +0530 wrote: > /**@{@name Rx hardware descriptor states > diff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h > index e55fb42996..4ffae4921a 100644 > --- a/lib/ethdev/rte_ethdev_core.h > +++ b/lib/ethdev/rte_ethdev_core.h > @@ -45,7 +45,7 @@ type

RE: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-12 Thread Morten Brørup
> From: Sunil Kumar Kori > Sent: Monday, 12 May 2025 17.07 > > As rte_eth_rx_queue_count() returns signed value to represent > the error cases but internally invoked callback is returning > unsigned value. Hence unnecessary type conversion is done. > > To avoid this typecasting from signed to un

[PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-12 Thread skori
From: Sunil Kumar Kori As rte_eth_rx_queue_count() returns signed value to represent the error cases but internally invoked callback is returning unsigned value. Hence unnecessary type conversion is done. To avoid this typecasting from signed to unsigned, fixed return type of callback functions.