Re: [PATCH v2 1/2] build: change flag variable type to boolean

2023-06-13 Thread Bruce Richardson
On Tue, Jun 13, 2023 at 03:43:34PM +0200, David Marchand wrote: > On Mon, Jun 12, 2023 at 7:15 PM Bruce Richardson > wrote: > > > > The has_libnuma flag was using 0 and 1 integer values, instead of the > > more appropriate boolean type. Change to use true/false instead. > > > > Signed-off-by: Bruc

Re: [PATCH v2 1/2] build: change flag variable type to boolean

2023-06-13 Thread David Marchand
On Mon, Jun 12, 2023 at 7:15 PM Bruce Richardson wrote: > > The has_libnuma flag was using 0 and 1 integer values, instead of the > more appropriate boolean type. Change to use true/false instead. > > Signed-off-by: Bruce Richardson This patch lgtm (with or without the suggestion on config/arm b

[PATCH v2 1/2] build: change flag variable type to boolean

2023-06-12 Thread Bruce Richardson
The has_libnuma flag was using 0 and 1 integer values, instead of the more appropriate boolean type. Change to use true/false instead. Signed-off-by: Bruce Richardson --- config/arm/meson.build| 2 +- config/meson.build| 4 ++-- lib/eal/linux/meson.build | 2 +- lib/vhost/meson.build