Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

> I like the sound of this idea a lot actually since it would remove the > chance of the output just completely being thrown away. In my own test > suite I managed to dance around this by strategically placing my > testpmd commands, but this could save people some headache in the > future. I feel l

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

On Fri, Aug 2, 2024 at 10:54 AM Nicholas Pratte wrote: > > > > You're right that in most cases it would come from the stop output, > > but the output from that stop command has one other thing as well that > > I would consider valuable which is statistics of packets handled by > > ports specifica

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

> You're right that in most cases it would come from the stop output, > but the output from that stop command has one other thing as well that > I would consider valuable which is statistics of packets handled by > ports specifically for the duration of the packet forwarding you are > stopping. It

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

On Thu, Aug 1, 2024 at 4:43 AM Luca Vizzarro wrote: > > On 30/07/2024 22:33, Jeremy Spewock wrote: > > On Tue, Jul 30, 2024 at 9:37 AM wrote: > > > >> +class VerboseOLFlag(Flag): > >> +"""Flag representing the OL flags of a packet from Testpmd verbose > >> output.""" > >> + > >> +#: > >

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

On Thu, Aug 1, 2024 at 4:41 AM Luca Vizzarro wrote: > > Great work Jeremy! Just a couple of minor passable improvement points. > > On 30/07/2024 14:34, jspew...@iol.unh.edu wrote: > > > +@dataclass > > +class TestPmdVerbosePacket(TextParser): > > +"""Packet information provided by verbose outp

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

On 30/07/2024 22:33, Jeremy Spewock wrote: On Tue, Jul 30, 2024 at 9:37 AM wrote: +class VerboseOLFlag(Flag): +"""Flag representing the OL flags of a packet from Testpmd verbose output.""" + +#: +RTE_MBUF_F_RX_RSS_HASH = auto() + +#: +RTE_MBUF_F_RX_L4_CKSUM_GOOD = auto() +

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

Great work Jeremy! Just a couple of minor passable improvement points. On 30/07/2024 14:34, jspew...@iol.unh.edu wrote: +@dataclass +class TestPmdVerbosePacket(TextParser): +"""Packet information provided by verbose output in Testpmd. + +The "receive/sent queue" information is not inclu

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

On Tue, Jul 30, 2024 at 9:37 AM wrote: > > class TestPmdDevice: > @@ -577,6 +577,128 @@ class TestPmdPortStats(TextParser): > tx_bps: int = field(metadata=TextParser.find_int(r"Tx-bps:\s+(\d+)")) > > > +class VerboseOLFlag(Flag): > +"""Flag representing the OL flags of a packet from Tes

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

On Tue, Jul 30, 2024 at 11:41 AM Nicholas Pratte wrote: > > Good work! I left some probing/clarifying comments below for you. > > > > +@dataclass > > +class TestPmdVerboseOutput(TextParser): > > +"""Verbose output generated by Testpmd. > > + > > +This class is the top level of the output,

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

Good work! I left some probing/clarifying comments below for you. > +@dataclass > +class TestPmdVerboseOutput(TextParser): > +"""Verbose output generated by Testpmd. > + > +This class is the top level of the output, containing verbose output > delimited by > +"port X/queue Y: sent/re

[PATCH v2 1/1] dts: add text parser for testpmd verbose output

From: Jeremy Spewock Multiple test suites from the old DTS framework rely on being able to consume and interpret the verbose output of testpmd. The new framework doesn't have an elegant way for handling the verbose output, but test suites are starting to be written that rely on it. This patch cre