Re: [PATCH v2 05/18] net/r8169: add support for hw config

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 05:45:18 + 王颢 wrote: > Dear Stephen, > > As you can see, there are some issues with the current code regarding > whitespace and CODE_INDENT. I used astyle to adjust the code format with the > following command. However, I found that I could not fully meet the > checkpa

答复: [PATCH v2 05/18] net/r8169: add support for hw config

2024-10-17 Thread 王颢
@dpdk.org; pro_nic_d...@realtek.com 主题: Re: [PATCH v2 05/18] net/r8169: add support for hw config External mail. On Thu, 17 Oct 2024 14:31:47 +0800 Howard Wang wrote: > Implement the rtl_hw_config function to configure the hardware. > > Signed-off-by: Howard Wang More indent

Re: [PATCH v2 05/18] net/r8169: add support for hw config

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 14:31:47 +0800 Howard Wang wrote: > Implement the rtl_hw_config function to configure the hardware. > > Signed-off-by: Howard Wang More indent issues flagged in this patch ERROR:CODE_INDENT: code indent should use tabs where possible #292: FILE: drivers/net/r8169/r8169_hw.

[PATCH v2 05/18] net/r8169: add support for hw config

2024-10-16 Thread Howard Wang
Implement the rtl_hw_config function to configure the hardware. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 125 ++ drivers/net/r8169/r8169_ethdev.c | 2 + drivers/net/r8169/r8169_ethdev.h | 15 +- drivers/net/r8169/r8169_hw.