RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-26 Thread Akhil Goyal
> > > /** > > > + * Asymmetric crypto key exchange operation type */ enum > > > +rte_crypto_asym_ke_type { > > > + RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE, > > > > Is it better to shorten it to > > RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE > > RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE > +1, Actually I am no

RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 26, 2022 12:58 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange > operation enum > > > /** > >

RE: [EXT] [PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-26 Thread Akhil Goyal
> /** > + * Asymmetric crypto key exchange operation type > + */ > +enum rte_crypto_asym_ke_type { > + RTE_CRYPTO_ASYM_KE_PRIVATE_KEY_GENERATE, Is it better to shorten it to RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE > + /**< Private Key generation operatio

[PATCH v2 03/14] cryptodev: separate key exchange operation enum

2022-05-25 Thread Arek Kusztal
- Separated key exchange enum from asym op type. Key exchange and asymmetric crypto operations like signatures, encryption/decryption should not share same operation enum as its use cases are unrelated and mutually exclusive. Therefore op_type was separate into: 1) operation type 2) key exchange op