RE: [PATCH v2 00/71] replace use of fixed size rte_mempcy

2024-03-02 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, 2 March 2024 17.38 > > On Sat, 2 Mar 2024 14:05:45 +0100 > Morten Brørup wrote: > > > > > > > > My experience with replacing rte_memcpy() with memcpy() (or vice > > > versa) > > > > is mixed. > > > > > > > > I've als

Re: [PATCH v2 00/71] replace use of fixed size rte_mempcy

2024-03-02 Thread Stephen Hemminger
On Sat, 2 Mar 2024 14:05:45 +0100 Morten Brørup wrote: > > > > > My experience with replacing rte_memcpy() with memcpy() (or vice > > versa) > > > is mixed. > > > > > > I've also tried just dropping the DPDK-custom memcpy() implementation > > > altogether, and that caused a performance dro

Re: [PATCH v2 00/71] replace use of fixed size rte_mempcy

2024-03-02 Thread Stephen Hemminger
On Sat, 2 Mar 2024 13:01:51 +0100 Mattias Rönnblom wrote: > I ran some DSW benchmarks, and if you add > > diff --git a/lib/eal/x86/include/rte_memcpy.h > b/lib/eal/x86/include/rte_memcpy.h > index 72a92290e0..64cd82d78d 100644 > --- a/lib/eal/x86/include/rte_memcpy.h > +++ b/lib/eal/x86/include

RE: [PATCH v2 00/71] replace use of fixed size rte_mempcy

2024-03-02 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Saturday, 2 March 2024 13.02 > > On 2024-03-02 12:14, Mattias Rönnblom wrote: > > On 2024-03-01 18:14, Stephen Hemminger wrote: > >> The DPDK has a lot of "cargo cult" usage of rte_memcpy. > >> This patch set replaces cases where rte_

Re: [PATCH v2 00/71] replace use of fixed size rte_mempcy

2024-03-02 Thread Mattias Rönnblom
On 2024-03-02 12:14, Mattias Rönnblom wrote: On 2024-03-01 18:14, Stephen Hemminger wrote: The DPDK has a lot of "cargo cult" usage of rte_memcpy. This patch set replaces cases where rte_memcpy is used with a fixed size constant size. Typical example is: rte_memcpy(mac_addrs, mac.addr_bytes

Re: [PATCH v2 00/71] replace use of fixed size rte_mempcy

2024-03-02 Thread Mattias Rönnblom
On 2024-03-01 18:14, Stephen Hemminger wrote: The DPDK has a lot of "cargo cult" usage of rte_memcpy. This patch set replaces cases where rte_memcpy is used with a fixed size constant size. Typical example is: rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN); which can be replac

Re: [PATCH v2 00/71] replace use of fixed size rte_mempcy

2024-03-01 Thread Tyler Retzlaff
On Fri, Mar 01, 2024 at 09:14:56AM -0800, Stephen Hemminger wrote: > The DPDK has a lot of "cargo cult" usage of rte_memcpy. > This patch set replaces cases where rte_memcpy is used with a fixed > size constant size. > > Typical example is: > rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_A

[PATCH v2 00/71] replace use of fixed size rte_mempcy

2024-03-01 Thread Stephen Hemminger
The DPDK has a lot of "cargo cult" usage of rte_memcpy. This patch set replaces cases where rte_memcpy is used with a fixed size constant size. Typical example is: rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN); which can be replaced with: memcpy(mac_addrs, mac.addr_byte