Re: [PATCH v2] usertools: rewrite pmdinfo

2022-09-15 Thread Robin Jarry
Ferruh Yigit, Sep 14, 2022 at 13:46: > I think better to display name, if there is nothing else to display, > comparing to not display anything at all. > Command can be run on the driver object, .so, so user expects to see > some output. > > For above enetfec driver, it is virtual driver and does

Re: [PATCH v2] usertools: rewrite pmdinfo

2022-09-14 Thread Ferruh Yigit
On 9/13/2022 10:22 PM, Robin Jarry wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Ferruh Yigit, Sep 13, 2022 at 22:54: Some of the drivers doesn't provide PCI i

Re: [PATCH v2] usertools: rewrite pmdinfo

2022-09-13 Thread Robin Jarry
Ferruh Yigit, Sep 13, 2022 at 22:54: > Some of the drivers doesn't provide PCI ids, but script is listing > them empty, like [1], is it better to omit the output for that case, > as done to 'params' & 'kmod'? [snip] > [1] >{ > "name": "net_enetfec", > "pci_ids": [] >}, I could in

Re: [PATCH v2] usertools: rewrite pmdinfo

2022-09-13 Thread Ferruh Yigit
On 9/13/2022 8:42 PM, Robin Jarry wrote: dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag merely prints multiple independent JSON lines which cannot be fed directly to any JSON parser. Moreover, the script complexity is rather high for such a simple task: extracting PMD_

[PATCH v2] usertools: rewrite pmdinfo

2022-09-13 Thread Robin Jarry
dpdk-pmdinfo.py does not produce any parseable output. The -r/--raw flag merely prints multiple independent JSON lines which cannot be fed directly to any JSON parser. Moreover, the script complexity is rather high for such a simple task: extracting PMD_INFO_STRING from .rodata ELF sections. Rewrit