Re: [PATCH v2] service: extend service function call statistics

2024-10-03 Thread Van Haaren, Harry
> From: Mattias Rönnblom > Sent: Wednesday, October 2, 2024 8:43 PM > To: Marchand, David > Cc: Mattias Rönnblom ; dev@dpdk.org > ; Van Haaren, Harry ; Stefan > Sundkvist > Subject: Re: [PATCH v2] service: extend service function call statistics > > On 2024-10-02

Re: [PATCH v2] service: extend service function call statistics

2024-10-02 Thread Mattias Rönnblom
On 2024-10-02 21:08, David Marchand wrote: On Wed, Oct 2, 2024 at 8:57 PM Mattias Rönnblom wrote: Coverity flagged this patch with issue #445158. rte_delay_ms() is now unreachable. I suppose this delay is not that important for the unit test and we can remove it, but as I am not sure I'll let

Re: [PATCH v2] service: extend service function call statistics

2024-10-02 Thread David Marchand
On Wed, Oct 2, 2024 at 8:57 PM Mattias Rönnblom wrote: > > Coverity flagged this patch with issue #445158. > > rte_delay_ms() is now unreachable. > > > > I suppose this delay is not that important for the unit test and we > > can remove it, but as I am not sure I'll let you have a look and send >

Re: [PATCH v2] service: extend service function call statistics

2024-10-02 Thread Mattias Rönnblom
On 2024-10-02 20:26, David Marchand wrote: Hello Mattias, On Mon, Sep 9, 2024 at 9:28 PM Mattias Rönnblom wrote: @@ -46,9 +49,21 @@ testsuite_teardown(void) static int32_t dummy_cb(void *args) { RTE_SET_USED(args); - service_tick++; + + service_calls++; + + switc

Re: [PATCH v2] service: extend service function call statistics

2024-10-02 Thread David Marchand
Hello Mattias, On Mon, Sep 9, 2024 at 9:28 PM Mattias Rönnblom wrote: > @@ -46,9 +49,21 @@ testsuite_teardown(void) > static int32_t dummy_cb(void *args) > { > RTE_SET_USED(args); > - service_tick++; > + > + service_calls++; > + > + switch (rte_rand_max(3)) { > +

Re: [PATCH v2] service: extend service function call statistics

2024-10-01 Thread David Marchand
On Mon, Sep 9, 2024 at 9:28 PM Mattias Rönnblom wrote: > > Add two new per-service counters. > > RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function > invocations where no work was performed. > > RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations > resulting in an e

Re: [PATCH v2] service: extend service function call statistics

2024-09-12 Thread Van Haaren, Harry
> From: Mattias Rönnblom > Sent: Monday, September 9, 2024 8:11 PM > To: dev@dpdk.org > Cc: hof...@lysator.liu.se ; Van Haaren, Harry > ; Stefan Sundkvist > ; Mattias Rönnblom > > Subject: [PATCH v2] service: extend service function call statistics > > Ad

Re: [PATCH v2] service: extend service function call statistics

2024-09-10 Thread Mattias Rönnblom
On 2024-09-10 03:19, fengchengwen wrote: Acked-by: Chengwen Feng Thanks. Harry, could we have a maintainer opinion on this patch? On 2024/9/10 3:11, Mattias Rönnblom wrote: Add two new per-service counters. RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function invocation

Re: [PATCH v2] service: extend service function call statistics

2024-09-09 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/9/10 3:11, Mattias Rönnblom wrote: > Add two new per-service counters. > > RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function > invocations where no work was performed. > > RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations > resu

[PATCH v2] service: extend service function call statistics

2024-09-09 Thread Mattias Rönnblom
Add two new per-service counters. RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function invocations where no work was performed. RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations resulting in an error. The semantics of RTE_SERVICE_ATTR_CALL_COUNT remains the same (