Re: [PATCH v2] net/vmxnet3: fix a missing vmxnet3 register command

2024-04-22 Thread Ronak Doshi
Basically it will just provide incorrect information. With the enum being misaligned due to missing command, GET_DCR0_REG and GET_MAX_CAPABILITIES will just lead to incorrect commands being issued. Thanks, Ronak On Fri, Apr 19, 2024 at 1:35 AM Ferruh Yigit wrote: > On 4/18/2024 7:36 AM, Ronak

Re: [PATCH v2] net/vmxnet3: fix a missing vmxnet3 register command

2024-04-19 Thread Ferruh Yigit
On 4/18/2024 7:36 AM, Ronak Doshi wrote: > Vmxnet3 uses capability registers to advertise the supported > capabilities of UPT device. It uses DCR0_REG command register > for this purpose. However, the register command enum misses > one command which technically is not used by dpdk vmxnet3 > driver

[PATCH v2] net/vmxnet3: fix a missing vmxnet3 register command

2024-04-17 Thread Ronak Doshi
Vmxnet3 uses capability registers to advertise the supported capabilities of UPT device. It uses DCR0_REG command register for this purpose. However, the register command enum misses one command which technically is not used by dpdk vmxnet3 driver yet. This can cause issue for commands added later.