On 13/02/2023 07:16, Ke Zhang wrote:
The control thread accesses the hardware resources after the
resources were released, resulting in a segment error.
This commit fixes the bug by exiting thread before resource released.
Please add the "Fixes: xyz" tag for the commit that introduced this bu
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, February 20, 2023 8:30 AM
> To: Tyler Retzlaff ; Zhang, Ke1X
>
> Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming
> ; dev@dpdk.org; david.march...@redhat.com
> Subject: Re: [PATCH v2] net/ice: fix ice
16/02/2023 08:53, Zhang, Ke1X:
> From: Thomas Monjalon
> > 13/02/2023 08:16, Ke Zhang:
> > > --- a/lib/eal/windows/include/pthread.h
> > > +++ b/lib/eal/windows/include/pthread.h
> > > +static inline void
> > > +pthread_exit(__rte_unused void *__retval) { }
> >
> > Please don't add more shim laye
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, February 14, 2023 7:03 PM
> To: Zhang, Ke1X
> Cc: Zhang, Qi Z ; Yang, Qiming
> ; dev@dpdk.org; Tyler Retzlaff
>
> Subject: Re: [PATCH v2] net/ice: fix ice dcf control thread crash
>
> 13/02/2
13/02/2023 08:16, Ke Zhang:
> --- a/lib/eal/windows/include/pthread.h
> +++ b/lib/eal/windows/include/pthread.h
> +static inline void
> +pthread_exit(__rte_unused void *__retval)
> +{
> +}
Please don't add more shim layer.
There is a new layer rte_thread_* in lib/eal/include/rte_thread.h
The control thread accesses the hardware resources after the
resources were released, resulting in a segment error.
This commit fixes the bug by exiting thread before resource released.
Signed-off-by: Ke Zhang
---
v2: add pthread_exit() for windows
---
drivers/net/ice/ice_dcf.c | 4
6 matches
Mail list logo
