RE: [PATCH v2] mempool: micro-optimize put function

2022-12-23 Thread Konstantin Ananyev
> > Hi Morten, > > > > > PING mempool maintainers. > > > > > > If you don't provide ACK or Review to patches, how should Thomas know > > that it is ready for merging? > > > > > > -Morten > > > > The code changes itself looks ok to me. > > Though I don't think it would really bring any noticeable

RE: [PATCH v2] mempool: micro-optimize put function

2022-12-22 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Thursday, 22 December 2022 14.52 > > Hi Morten, > > > PING mempool maintainers. > > > > If you don't provide ACK or Review to patches, how should Thomas know > that it is ready for merging? > > > > -Morten > > The code cha

RE: [PATCH v2] mempool: micro-optimize put function

2022-12-22 Thread Konstantin Ananyev
Hi Morten, > PING mempool maintainers. > > If you don't provide ACK or Review to patches, how should Thomas know that it > is ready for merging? > > -Morten The code changes itself looks ok to me. Though I don't think it would really bring any noticeable speedup. But yes, it looks a bit nice

RE: [PATCH v2] mempool: micro-optimize put function

2022-12-19 Thread Morten Brørup
PING mempool maintainers. If you don't provide ACK or Review to patches, how should Thomas know that it is ready for merging? -Morten > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Wednesday, 16 November 2022 18.39 > > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha..

RE: [PATCH v2] mempool: micro-optimize put function

2022-11-16 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, 16 November 2022 17.27 > > > > > > > > > > > Micro-optimization: > > > > Reduced the most likely code path in the generic put function by > > > moving an > > > > unlikely check out of the most likely code path

RE: [PATCH v2] mempool: micro-optimize put function

2022-11-16 Thread Honnappa Nagarahalli
> > > > > > Micro-optimization: > > > Reduced the most likely code path in the generic put function by > > moving an > > > unlikely check out of the most likely code path and further down. > > > > > > Also updated the comments in the function. > > > > > > v2 (feedback from Andrew Rybchenko): > >

RE: [PATCH v2] mempool: micro-optimize put function

2022-11-16 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, 16 November 2022 16.51 > > > > > > Micro-optimization: > > Reduced the most likely code path in the generic put function by > moving an > > unlikely check out of the most likely code path and further down. > > >

RE: [PATCH v2] mempool: micro-optimize put function

2022-11-16 Thread Honnappa Nagarahalli
> > Micro-optimization: > Reduced the most likely code path in the generic put function by moving an > unlikely check out of the most likely code path and further down. > > Also updated the comments in the function. > > v2 (feedback from Andrew Rybchenko): > * Modified comparison to prevent ove

[PATCH v2] mempool: micro-optimize put function

2022-11-16 Thread Morten Brørup
Micro-optimization: Reduced the most likely code path in the generic put function by moving an unlikely check out of the most likely code path and further down. Also updated the comments in the function. v2 (feedback from Andrew Rybchenko): * Modified comparison to prevent overflow if n is really