Re: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-06 Thread Aaron Conole
Morten Brørup writes: > @Aaron, do you have any insights or comments to my curiosity below? Sorry, the perf tests from Feb to Oct should *generally* be comparable but keep in mind that they are based on different baseline versions of DPDK. Also, the perf tests are done as thresholds rather than

RE: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Tuesday, 4 October 2022 17.59 > > On 10/4/22 18:13, Morten Brørup wrote: > > @Aaron, do you have any insights or comments to my curiosity below? > > > >> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > >> Sent:

[PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
RESENT for test purposes. A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() was not completely updated back then, and some inefficiencies were introduced. This patch fixes the following in rte_mempool_do_generic_get(): 1. The code that i

RE: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
RESENT for test purposes. A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() was not completely updated back then, and some inefficiencies were introduced. This patch fixes the following in rte_mempool_do_generic_get(): 1. The code that i

[PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
RESENT for test purposes. A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() was not completely updated back then, and some inefficiencies were introduced. This patch fixes the following in rte_mempool_do_generic_get(): 1. The code that

Re: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Andrew Rybchenko
On 10/4/22 18:13, Morten Brørup wrote: @Aaron, do you have any insights or comments to my curiosity below? From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] Sent: Tuesday, 4 October 2022 14.58 Hi Morten, In general I agree that the fix is required. In sent v3 I'm trying to make it

RE: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Morten Brørup
@Aaron, do you have any insights or comments to my curiosity below? > From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Tuesday, 4 October 2022 14.58 > > Hi Morten, > > In general I agree that the fix is required. > In sent v3 I'm trying to make it a bit better from my point

Re: [PATCH v2] mempool: fix get objects from mempool with cache

2022-10-04 Thread Andrew Rybchenko
Hi Morten, In general I agree that the fix is required. In sent v3 I'm trying to make it a bit better from my point of view. See few notes below. On 2/2/22 11:14, Morten Brørup wrote: A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() wa

RE: [PATCH v2] mempool: fix get objects from mempool with cache

2022-09-29 Thread Morten Brørup
PING again. If the explanation and/or diff is too longwinded, just look at the resulting code instead - it is clean and easily readable. This patch should not be controversial, so I would like to see it merged into the coming LTS release. (Unlike my other mempool patch [3], which changes the b

RE: [PATCH v2] mempool: fix get objects from mempool with cache

2022-06-15 Thread Morten Brørup
+CC: Beilei Xing , i40e maintainer, may be interested in the performance improvements achieved by this patch. > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Wednesday, 2 February 2022 09.14 > > A flush threshold for the mempool cache was introduced in DPDK version > 1.3, but r

[PATCH v2] mempool: fix get objects from mempool with cache

2022-02-02 Thread Morten Brørup
A flush threshold for the mempool cache was introduced in DPDK version 1.3, but rte_mempool_do_generic_get() was not completely updated back then, and some inefficiencies were introduced. This patch fixes the following in rte_mempool_do_generic_get(): 1. The code that initially screens the cache