RE: [EXT] Re: [PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning

2023-05-24 Thread Akhil Goyal
> On Tue, 23 May 2023 08:12:28 + > Akhil Goyal wrote: > > > > > > > This could happen if the passed in length to this routine was larger than > > > the amount of data in the mbuf. Should the function check and return an > error? > > > > > > Panic should only be reserved for seriously corrupte

Re: [EXT] Re: [PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning

2023-05-23 Thread Stephen Hemminger
On Tue, 23 May 2023 08:12:28 + Akhil Goyal wrote: > > > > This could happen if the passed in length to this routine was larger than > > the amount of data in the mbuf. Should the function check and return an > > error? > > > > Panic should only be reserved for seriously corrupted input (li

RE: [EXT] Re: [PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning

2023-05-23 Thread Akhil Goyal
> On Mon, 22 May 2023 15:04:52 -0400 > Kamil Godzwon wrote: > > > /home/vagrant/dpdk/build/include/rte_crypto_sym.h:1009:4: \ > > warning: Value stored to 'left' is never read [deadcode.DeadStores] > > left = 0; > > ^ ~ > > 1 warning gene

Re: [PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning

2023-05-22 Thread Stephen Hemminger
On Mon, 22 May 2023 15:04:52 -0400 Kamil Godzwon wrote: > /home/vagrant/dpdk/build/include/rte_crypto_sym.h:1009:4: \ > warning: Value stored to 'left' is never read [deadcode.DeadStores] > left = 0; > ^ ~ > 1 warning generated. > > Comp

[PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning

2023-05-22 Thread Kamil Godzwon
/home/vagrant/dpdk/build/include/rte_crypto_sym.h:1009:4: \ warning: Value stored to 'left' is never read [deadcode.DeadStores] left = 0; ^ ~ 1 warning generated. Compilator sees that the variable 'left' is never read after assignment a '0