Re: [PATCH v2] kni: remove deprecated kernel network interface

2023-08-01 Thread David Marchand
Hello Stephen, While rebasing, please also fix those nits: On Sun, Jul 30, 2023 at 4:12 AM Stephen Hemminger wrote: > diff --git a/doc/guides/contributing/documentation.rst > b/doc/guides/contributing/documentation.rst > index 7fcbb7fc43b2..f16c94e9768b 100644 > --- a/doc/guides/contributing/do

Re: [PATCH v2] kni: remove deprecated kernel network interface

2023-07-31 Thread Thomas Monjalon
31/07/2023 23:12, Stephen Hemminger: > On Mon, 31 Jul 2023 10:40:35 +0200 > Thomas Monjalon wrote: > > > > 2. The OVSrobot is looking into the port library to see the kni symbols. > > > But port is marked as deprecated already. > > > Perhaps we should just pull out port first? > > > > No we mu

Re: [PATCH v2] kni: remove deprecated kernel network interface

2023-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2023 10:40:35 +0200 Thomas Monjalon wrote: > > 2. The OVSrobot is looking into the port library to see the kni symbols. > > But port is marked as deprecated already. > > Perhaps we should just pull out port first? > > No we must support it until it is removed. > You should eithe

Re: [PATCH v2] kni: remove deprecated kernel network interface

2023-07-31 Thread Thomas Monjalon
31/07/2023 17:13, Stephen Hemminger: > On Mon, 31 Jul 2023 10:40:35 +0200 > Thomas Monjalon wrote: > > > 30/07/2023 19:12, Stephen Hemminger: > > > On Sat, 29 Jul 2023 19:12:05 -0700 > > > Stephen Hemminger wrote: > > > > > > > Deprecation and removal was announced in 22.11. > > > > Make it s

Re: [PATCH v2] kni: remove deprecated kernel network interface

2023-07-31 Thread David Marchand
On Mon, Jul 31, 2023 at 5:13 PM Stephen Hemminger wrote: > > > 2. The OVSrobot is looking into the port library to see the kni symbols. > > > But port is marked as deprecated already. > > > Perhaps we should just pull out port first? > > > > No we must support it until it is removed. > > You shoul

Re: [PATCH v2] kni: remove deprecated kernel network interface

2023-07-31 Thread Stephen Hemminger
On Mon, 31 Jul 2023 10:40:35 +0200 Thomas Monjalon wrote: > 30/07/2023 19:12, Stephen Hemminger: > > On Sat, 29 Jul 2023 19:12:05 -0700 > > Stephen Hemminger wrote: > > > > > Deprecation and removal was announced in 22.11. > > > Make it so. > > Would be good to summarize the reason here, >

Re: [PATCH v2] kni: remove deprecated kernel network interface

2023-07-31 Thread Thomas Monjalon
30/07/2023 19:12, Stephen Hemminger: > On Sat, 29 Jul 2023 19:12:05 -0700 > Stephen Hemminger wrote: > > > Deprecation and removal was announced in 22.11. > > Make it so. Would be good to summarize the reason here, and name replacements. Also it should not be completely removed. I think we were

Re: [PATCH v2] kni: remove deprecated kernel network interface

2023-07-30 Thread Stephen Hemminger
On Sat, 29 Jul 2023 19:12:05 -0700 Stephen Hemminger wrote: > Deprecation and removal was announced in 22.11. > Make it so. > > Leave kernel/linux with empty directory because > CI is trying to directly build it. At some later date, > kernel/linux can be removed. > > Signed-off-by: Stephen Hemm