Re:RE: [PATCH v2] ip_frag: add IPv4 options fragment and test data

2022-02-20 Thread Huichao Cai
Hi Konstantin, >Who will define this macro and when? >In general we trying to avoid conditional compilations within DPDK. >Can we always use one way or another? >As you are doing a copy anyway, probably no harm just >completely remove RTE_IPOPT_KEEP_IP_HLEN and related behaviour >and copy only op

RE: [PATCH v2] ip_frag: add IPv4 options fragment and test data

2022-02-18 Thread Ananyev, Konstantin
Hi Huichao, > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting proce

[PATCH v2] ip_frag: add IPv4 options fragment and test data

2022-02-15 Thread Huichao Cai
According to RFC791,the options may appear or not in datagrams. They must be implemented by all IP modules (host and gateways). What is optional is their transmission in any particular datagram, not their implementation.So we have to deal with it during the fragmenting process.Add some test data fo