Re: [PATCH v2] hash: provide crc32 functions based on intrinsics

2024-05-26 Thread Thomas Monjalon
22/05/2024 10:36, Morten Brørup: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 22 May 2024 04.21 > > > > On Tue, 21 May 2024 17:02:14 -0700 > > Tyler Retzlaff wrote: > > > > > MSVC does not support inline asm so replace crc32 inline function > > > implement

RE: [PATCH v2] hash: provide crc32 functions based on intrinsics

2024-05-22 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 22 May 2024 04.21 > > On Tue, 21 May 2024 17:02:14 -0700 > Tyler Retzlaff wrote: > > > MSVC does not support inline asm so replace crc32 inline function > > implementations with intrinsics compatible with all toolch

Re: [PATCH v2] hash: provide crc32 functions based on intrinsics

2024-05-21 Thread Stephen Hemminger
On Tue, 21 May 2024 17:02:14 -0700 Tyler Retzlaff wrote: > MSVC does not support inline asm so replace crc32 inline function > implementations with intrinsics compatible with all toolchains. > > Signed-off-by: Tyler Retzlaff > --- always good to remove asm since in tends not to get optimized.

[PATCH v2] hash: provide crc32 functions based on intrinsics

2024-05-21 Thread Tyler Retzlaff
MSVC does not support inline asm so replace crc32 inline function implementations with intrinsics compatible with all toolchains. v2: * just provide inline functions based on intrinsics and remove inline asm versions. Tyler Retzlaff (1): hash: provide crc32 functions based on intrinsi

[PATCH v2] hash: provide crc32 functions based on intrinsics

2024-05-21 Thread Tyler Retzlaff
MSVC does not support inline asm so replace crc32 inline function implementations with intrinsics compatible with all toolchains. Signed-off-by: Tyler Retzlaff --- lib/hash/rte_crc_x86.h | 38 +- 1 file changed, 13 insertions(+), 25 deletions(-) diff --git a/