Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-10 Thread Jerin Jacob
On Thu, Aug 10, 2023 at 5:28 PM Naga Harish K, S V wrote: > > Hi Jerin, > Thinking of another approach for this patch. > Instead of changing all create APIs, update > rte_event_eth_rx_adapter_create_ext() alone with additional parameters. > rte_event_eth_rx_adapter_create() and > rte_event

RE: [PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-10 Thread Naga Harish K, S V
this approach? -Harish > -Original Message- > From: Jerin Jacob > Sent: Thursday, August 10, 2023 1:37 PM > To: Naga Harish K, S V > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs > > On Thu, Aug

Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-10 Thread Jerin Jacob
On Thu, Aug 10, 2023 at 1:09 PM Naga Harish K, S V wrote: > > Hi Jerin, > As per DPDK Guidelines, API changes or ABI breakage is allowed during > LTS releases > > (https://doc.dpdk.org/guides/contributing/abi_policy.html#abi-breakages) Yes. Provided if depreciation notice has sent

RE: [PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-10 Thread Naga Harish K, S V
the same. -Harish > -Original Message- > From: Jerin Jacob > Sent: Wednesday, August 2, 2023 9:42 PM > To: Naga Harish K, S V > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs > > On Wed, Aug 2, 2023 at

Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-02 Thread Jerin Jacob
resort. It is quite common have two APIs versions of single operation with more specialized parameters. > > -Harish > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, August 1, 2023 8:54 PM > > To: Naga Harish K, S V > > Cc: dev@dpdk

RE: [PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-02 Thread Naga Harish K, S V
Naga Harish K, S V > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs > > On Tue, Aug 1, 2023 at 7:22 PM Naga Harish K S V > wrote: > > > > The adapter create APIs such as rte_event_eth_rx_adapter_create_ext()

Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-01 Thread Jerin Jacob
On Tue, Aug 1, 2023 at 7:22 PM Naga Harish K S V wrote: > > The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and > rte_event_eth_rx_adapter_create() are updated to take additional argument > as a pointer of type struct rte_event_eth_rx_adapter_params. > > The API rte_event_eth

[PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-01 Thread Naga Harish K S V
The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and rte_event_eth_rx_adapter_create() are updated to take additional argument as a pointer of type struct rte_event_eth_rx_adapter_params. The API rte_event_eth_rx_adapter_create_with_params() is deprecated. Signed-off-by: Naga