Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-19 Thread Jeremy Spewock
On Thu, Sep 19, 2024 at 3:09 AM Juraj Linkeš wrote: > > > > On 18. 9. 2024 16:16, Jeremy Spewock wrote: > > On Wed, Sep 18, 2024 at 3:57 AM Juraj Linkeš > > wrote: > >> > >> > >>> diff --git a/dts/Dockerfile b/dts/Dockerfile > >> > >>> @@ -24,9 +27,12 @@ FROM base AS runner > >> > >>> +# Adds ~/

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-19 Thread Juraj Linkeš
On 19. 9. 2024 11:36, Juraj Linkeš wrote: diff --git a/dts/Dockerfile b/dts/Dockerfile @@ -24,9 +27,12 @@ FROM base AS runner   # It bakes DTS into the image during the build.   COPY . /dpdk/dts -RUN poetry install --no-dev +# Adds ~/.local/bin to PATH so that packages installed with pipx

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-19 Thread Juraj Linkeš
diff --git a/dts/Dockerfile b/dts/Dockerfile @@ -24,9 +27,12 @@ FROM base AS runner # It bakes DTS into the image during the build. COPY . /dpdk/dts -RUN poetry install --no-dev +# Adds ~/.local/bin to PATH so that packages installed with pipx are callable. `pipx ensurepath` +# fixe

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-19 Thread Juraj Linkeš
On 18. 9. 2024 16:16, Jeremy Spewock wrote: On Wed, Sep 18, 2024 at 3:57 AM Juraj Linkeš wrote: diff --git a/dts/Dockerfile b/dts/Dockerfile @@ -24,9 +27,12 @@ FROM base AS runner +# Adds ~/.local/bin to PATH so that packages installed with pipx are callable. `pipx ensurepath` +# f

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-18 Thread Jeremy Spewock
On Wed, Sep 18, 2024 at 3:57 AM Juraj Linkeš wrote: > > > > diff --git a/dts/Dockerfile b/dts/Dockerfile > > > @@ -24,9 +27,12 @@ FROM base AS runner > > > +# Adds ~/.local/bin to PATH so that packages installed with pipx are > > callable. `pipx ensurepath` > > +# fixes this issue, but requires t

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-18 Thread Juraj Linkeš
diff --git a/dts/Dockerfile b/dts/Dockerfile @@ -24,9 +27,12 @@ FROM base AS runner +# Adds ~/.local/bin to PATH so that packages installed with pipx are callable. `pipx ensurepath` +# fixes this issue, but requires the shell to be re-opened which isn't an option for this target. Let'

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-18 Thread Juraj Linkeš
On 17. 9. 2024 17:22, Patrick Robb wrote: Dean actually just came down with an illness. Since the changes in his series are minimal (I see the only ones left are updating dts.rst and the devcontainer json) I think that one of us at UNH should submit a patch which is essentially a v2 of his ser

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-17 Thread Patrick Robb
Dean actually just came down with an illness. Since the changes in his series are minimal (I see the only ones left are updating dts.rst and the devcontainer json) I think that one of us at UNH should submit a patch which is essentially a v2 of his series. It's probably not worth blocking a "critic

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-17 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

[PATCH v2] dts: fix runner target in the Dockerfile

2024-09-16 Thread jspewock
From: Jeremy Spewock Currently the runner target in the Dockerfile attempts to run the `poetry install` command when building the image, but this fails due to poetry not being found in the container. Poetry is installed in a previous step with pipx, but doing so adds the binary to use poetry to ~