On Tue, Jun 17, 2025 at 11:18 AM Luca Vizzarro
wrote:
> Looks good to me. just a small nit:
>
> On 16/06/2025 19:38, Dean Marx wrote:
> > +test_run.ctx.topology.setup()
> > +self.test_run.ctx.topology.configure_ports("sut", "dpdk")
>
> no need to do `self.` here. Outside of this:
Looks good to me. just a small nit:
On 16/06/2025 19:38, Dean Marx wrote:
+test_run.ctx.topology.setup()
+self.test_run.ctx.topology.configure_ports("sut", "dpdk")
no need to do `self.` here. Outside of this:
Reviewed-by: Luca Vizzarro
Thanks, looks good and I gave it a testrun on some XL710.
I'm going to include the Slack summary of the bugs for clarity on the v2:
Bugs:
1. topology setup is called before DPDKRuntimeEnvironment setup, but
DPDKRuntimeEnvironment setup is required for topology setup, so the
ordering needs to be r
Recheck-request: iol-intel-Functional
Rearrange the topology and DPDK setup/teardown calls during
test runs to ensure the devbind script is not called
while the DPDK tmp directory doesn't exist.
Fixes: 4cef16f1f0a4 ("dts: improve port handling")
Signed-off-by: Dean Marx
---
dts/framework/test_run.py | 5 +++--
1 file changed, 3 ins
Rearrange the topology and DPDK setup/teardown calls during
test runs to ensure the devbind script is not called
while the DPDK tmp directory doesn't exist.
Fixes: 4cef16f1f0a4 ("dts: improve port handling")
Signed-off-by: Dean Marx
---
dts/framework/test_run.py | 5 +++--
1 file changed, 3 ins
6 matches
Mail list logo
