Re: [PATCH v2] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-01-14 Thread Stephen Hemminger
On Tue, 14 Jan 2025 13:08:28 -0800 Andre Muezerie wrote: > > > > Patches to base driver need to be avoided if at all possible. > > Please resubmit without that part > > Thanks for the information. I sent out a v3 for this series. > It does contain _coding style issues_ for preexisting code. >

Re: [PATCH v2] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-01-14 Thread Andre Muezerie
On Tue, Jan 14, 2025 at 10:41:53AM -0800, Stephen Hemminger wrote: > On Mon, 6 Jan 2025 13:16:55 -0800 > Andre Muezerie wrote: > > > This patch avoids warnings like the ones below emitted by MSVC: > > > > 1) > > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': > > result of 32

Re: [PATCH v2] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-01-14 Thread Stephen Hemminger
On Mon, 6 Jan 2025 13:16:55 -0800 Andre Muezerie wrote: > This patch avoids warnings like the ones below emitted by MSVC: > > 1) > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > >

[PATCH v2] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

2025-01-06 Thread Andre Muezerie
This patch avoids warnings like the ones below emitted by MSVC: 1) ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) 2) ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=': signed