RE: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-14 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 14 June 2024 17.27 > > On Fri, 14 Jun 2024 10:01:02 +0100 > Ferruh Yigit wrote: > > > On 6/13/2024 8:13 PM, Stephen Hemminger wrote: > > > On Thu, 13 Jun 2024 17:51:14 +0100 > > > Ferruh Yigit wrote: > > > > > >>> Hi

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-14 Thread Ferruh Yigit
On 6/14/2024 4:27 PM, Stephen Hemminger wrote: > On Fri, 14 Jun 2024 10:01:02 +0100 > Ferruh Yigit wrote: > >> On 6/13/2024 8:13 PM, Stephen Hemminger wrote: >>> On Thu, 13 Jun 2024 17:51:14 +0100 >>> Ferruh Yigit wrote: >>> > Hi Sivaprasad, > > Is this '(lcoreid_t)' cast required

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-14 Thread Stephen Hemminger
On Fri, 14 Jun 2024 10:01:02 +0100 Ferruh Yigit wrote: > On 6/13/2024 8:13 PM, Stephen Hemminger wrote: > > On Thu, 13 Jun 2024 17:51:14 +0100 > > Ferruh Yigit wrote: > > > >>> Hi Sivaprasad, > >>> > >>> Is this '(lcoreid_t)' cast required? Because of integer promotion I > >>> think result wi

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-14 Thread Ferruh Yigit
On 6/13/2024 8:13 PM, Stephen Hemminger wrote: > On Thu, 13 Jun 2024 17:51:14 +0100 > Ferruh Yigit wrote: > >>> Hi Sivaprasad, >>> >>> Is this '(lcoreid_t)' cast required? Because of integer promotion I >>> think result will be correct without casting. >>> >>> (And without integer promotion consi

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-13 Thread Stephen Hemminger
On Thu, 13 Jun 2024 17:51:14 +0100 Ferruh Yigit wrote: > > Hi Sivaprasad, > > > > Is this '(lcoreid_t)' cast required? Because of integer promotion I > > think result will be correct without casting. > > > > (And without integer promotion considered, casting needs to be done on > > one of the v

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-13 Thread Ferruh Yigit
On 4/19/2024 12:30 PM, Ferruh Yigit wrote: > On 4/16/2024 10:55 AM, Sivaprasad Tummala wrote: >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >> index ba1007ace6..6b28c22c96 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -4785,9 +4785,9 @@ fwd_stream_on_oth

RE: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-06 Thread Tummala, Sivaprasad
Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2] app/testpmd: fix lcore ID restriction > > On 4/16/2024 10:55 AM, Sivaprasad Tummala wrote: > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > ba1007ace6..6b28c22c96 100644 > > --- a/app/t

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-04-19 Thread Ferruh Yigit
On 4/16/2024 10:55 AM, Sivaprasad Tummala wrote: > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index ba1007ace6..6b28c22c96 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -4785,9 +4785,9 @@ fwd_stream_on_other_lcores(uint16_t domain_id, > lcoreid_t src_lc,

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-04-19 Thread Ferruh Yigit
On 4/16/2024 10:55 AM, Sivaprasad Tummala wrote: > With modern CPUs, it is possible to have higher > CPU count thus we can have higher RTE_MAX_LCORES. > In testpmd application, the current config forwarding > cores option "--nb-cores" is hard limited to 255. > > The patch fixes this constraint and

[PATCH v2] app/testpmd: fix lcore ID restriction

2024-04-16 Thread Sivaprasad Tummala
With modern CPUs, it is possible to have higher CPU count thus we can have higher RTE_MAX_LCORES. In testpmd application, the current config forwarding cores option "--nb-cores" is hard limited to 255. The patch fixes this constraint and also adjusts the lcore data structure to 32-bit to align wit