Re: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-16 Thread Thomas Monjalon
15/10/2024 09:10, Mattias Rönnblom: > On 2024-10-15 08:41, Mattias Rönnblom wrote: > > On 2024-10-14 10:17, Morten Brørup wrote: > > > > >> > >>> +/** > >>> + * Get pointer to lcore variable instance with the specified lcore id. > >>> + * > >>> + * @param lcore_id > >>> + * The lcore id specif

Re: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-15 Thread Mattias Rönnblom
On 2024-10-15 09:39, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Tuesday, 15 October 2024 09.11 On 2024-10-15 08:41, Mattias Rönnblom wrote: On 2024-10-14 10:17, Morten Brørup wrote: Please remove the _VALUE suffix. You changed your mind? I'm missing t

RE: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-15 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Tuesday, 15 October 2024 08.42 > > On 2024-10-14 10:17, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >> Sent: Monday, 14 October 2024 09.44 > > > > > >> +struct lcore_var_buffer { > >> + c

RE: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-15 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Tuesday, 15 October 2024 09.11 > > On 2024-10-15 08:41, Mattias Rönnblom wrote: > > On 2024-10-14 10:17, Morten Brørup wrote: > > >> Please remove the _VALUE suffix. > >> > > > > You changed your mind? I'm missing the rationale here.

Re: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-15 Thread Mattias Rönnblom
On 2024-10-15 08:41, Mattias Rönnblom wrote: On 2024-10-14 10:17, Morten Brørup wrote: +/** + * Get pointer to lcore variable instance with the specified lcore id. + * + * @param lcore_id + *   The lcore id specifying which of the @c RTE_MAX_LCORE value + *   instances should be accessed.

Re: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Mattias Rönnblom
On 2024-10-14 10:17, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Monday, 14 October 2024 09.44 +struct lcore_var_buffer { + char data[RTE_MAX_LCORE_VAR * RTE_MAX_LCORE]; + struct lcore_var_buffer *prev; +}; In relation to Jerin's requ

RE: [PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Monday, 14 October 2024 09.44 > +struct lcore_var_buffer { > + char data[RTE_MAX_LCORE_VAR * RTE_MAX_LCORE]; > + struct lcore_var_buffer *prev; > +}; In relation to Jerin's request for using hugepages when available,

[PATCH v11 1/7] eal: add static per-lcore memory allocation facility

2024-10-14 Thread Mattias Rönnblom
Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically allocating small, frequently-accessed data structures, for which one instance should exist for each l