Re: [PATCH v1] dts: fix pass rate edge case in results json

2025-01-15 Thread Luca Vizzarro
On 15/01/2025 15:41, Dean Marx wrote: Also, I noticed after submitting this first version that suites where some cases are skipped and the rest pass have a 100% pass rate in the results report. Should this also mean that suites where every case is skipped have a 100% pass rate? Right now this rep

Re: [PATCH v1] dts: fix pass rate edge case in results json

2025-01-15 Thread Dean Marx
Also, I noticed after submitting this first version that suites where some cases are skipped and the rest pass have a 100% pass rate in the results report. Should this also mean that suites where every case is skipped have a 100% pass rate? Right now this reports a 0% when the entire suite is skipp

Re: [PATCH v1] dts: fix pass rate edge case in results json

2025-01-15 Thread Dean Marx
Got it, I can implement this asap

Re: [PATCH v1] dts: fix pass rate edge case in results json

2025-01-15 Thread Dean Marx
Got it, I can implement this asap. I also noticed after submitting that test suites with skipped cases still report a 100% pass rate if the non skipped cases still pass, so I'll probably change the pass rate to 100% for when an entire suite is skipped unless anyone disagrees.

Re: [PATCH v1] dts: fix pass rate edge case in results json

2025-01-15 Thread Luca Vizzarro
Hi Dean, good timing! I actually noticed this issue last week and was going to tackle it soon. On 13/01/2025 21:52, Dean Marx wrote: @@ -324,13 +324,15 @@ def generate_pass_rate_dict(self, test_run_summary) -> dict[str, float]: Returns: A dictionary with the PASS/FAI

[PATCH v1] dts: fix pass rate edge case in results json

2025-01-13 Thread Dean Marx
Add condition to results.json pass rate generation method which returns 0 as the pass rate when the suite is skipped, rather than causing a divide by 0 error. Fixes: 9f8a257235ac ("dts: improve test run result statistics") Signed-off-by: Dean Marx --- dts/framework/test_result.py | 16 +