Re: [PATCH v1] bbdev: allow operation type enum for growth

2022-06-23 Thread Ray Kinsella
Thomas Monjalon writes: > This solution is what I proposed to the techboard some years ago, > but the preference was to completely remove the MAX values. I am mindful we don't have an explicit guidance in the documentation. I am including to add something to the abi_versioning document, that

RE: [PATCH v1] bbdev: allow operation type enum for growth

2022-06-17 Thread Chautru, Nicolas
> From: Thomas Monjalon > > This solution is what I proposed to the techboard some years ago, but the > preference was to completely remove the MAX values. > Thanks, good to see you had similar thought! I don't believe there is an actual recommendation captured in term of how to remove compl

Re: [PATCH v1] bbdev: allow operation type enum for growth

2022-06-17 Thread Thomas Monjalon
This solution is what I proposed to the techboard some years ago, but the preference was to completely remove the MAX values. 13/06/2022 20:24, Nicolas Chautru: > Updating the last enum for rte_bbdev_op_type > to allow for enum insertion. Please explain that the reason is to keep ABI compatible,

RE: [PATCH v1] bbdev: allow operation type enum for growth

2022-06-13 Thread Chautru, Nicolas
xp.com; > david.march...@redhat.com > Subject: Re: [PATCH v1] bbdev: allow operation type enum for growth > > On Mon, 13 Jun 2022 11:24:35 -0700 > Nicolas Chautru wrote: > > > Updating the last enum for rte_bbdev_op_type to allow for enum > > insertion. > > >

Re: [PATCH v1] bbdev: allow operation type enum for growth

2022-06-13 Thread Stephen Hemminger
On Mon, 13 Jun 2022 11:24:35 -0700 Nicolas Chautru wrote: > Updating the last enum for rte_bbdev_op_type > to allow for enum insertion. > > Signed-off-by: Nicolas Chautru Only allowed if you check now for the any of the reserved types and fail.

[PATCH v1] bbdev: allow operation type enum for growth

2022-06-13 Thread Nicolas Chautru
Updating the last enum for rte_bbdev_op_type to allow for enum insertion. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.c| 5 - lib/bbdev/rte_bbdev_op.h | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index aae

[PATCH v1] bbdev: allow operation type enum for growth

2022-06-13 Thread Nicolas Chautru
Hi Thomas, I would like to get your view on this topic and best recommendation moving forward. This is related to the general intent to remove using MAX value for enums. There is consensus that we should avoid this for a while notably for future-proofed ABI concerns https://patches.dpdk.org/