Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

On 4/27/2023 4:59 PM, Ronak Doshi wrote: > > > On 4/27/23, 1:51 AM, "Ferruh Yigit" > wrote: >> >> README doesn't say much. >> >> The usage is not standard, and intention is not clear. >> Can you please dig this issue more to learn the the intention, may be we >> can

Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

> On 4/27/23, 1:51 AM, "Ferruh Yigit" mailto:ferruh.yi...@amd.com>> wrote: > > README doesn't say much. > > The usage is not standard, and intention is not clear. > Can you please dig this issue more to learn the the intention, may be we > can find a better way or get rid of them completely? Sur

Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

On 4/26/2023 6:27 PM, Ronak Doshi wrote: > > > On 4/26/23, 9:58 AM, "Ferruh Yigit" > wrote: > >> As far as I can see these "vmware_pack_begin.h" & "vmware_pack_end.h" >> has only file license comment, and I can see this is used in a few other >> type declaration. >

Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

On 4/26/23, 9:58 AM, "Ferruh Yigit" mailto:ferruh.yi...@amd.com>> wrote: > As far as I can see these "vmware_pack_begin.h" & "vmware_pack_end.h" > has only file license comment, and I can see this is used in a few other > type declaration. > > What is the reasoning behind using these headers?

Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

On 4/12/2023 5:26 PM, Ronak Doshi wrote: > This patch adds a new command to set ring buffer sizes. This is > required to pass the buffer size information to passthrough devices. > Also, ring sizes are round down to power of 2. > > Signed-off-by: Ronak Doshi > Acked-by: Jochen Behrens > --- > dr

[PATCH next 4/7] vmxnet3: add command to set ring buffer sizes

This patch adds a new command to set ring buffer sizes. This is required to pass the buffer size information to passthrough devices. Also, ring sizes are round down to power of 2. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 15 ++