Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-07-17 Thread Ferruh Yigit
On 7/16/2024 5:33 PM, Patrick Robb wrote: > On Wed, Feb 14, 2024 at 3:17 PM Patrick Robb wrote: >> >> >> >> On Wed, Feb 14, 2024 at 3:00 PM Dumitrescu, Cristian >> wrote: >>> >>> >>> >>> [Cristian] >>> Yes, you are right, we do have a DTS test suite for the pipeline library. >>> >>> It would be

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-07-16 Thread Patrick Robb
On Wed, Feb 14, 2024 at 3:17 PM Patrick Robb wrote: > > > > On Wed, Feb 14, 2024 at 3:00 PM Dumitrescu, Cristian > wrote: >> >> >> >> [Cristian] >> Yes, you are right, we do have a DTS test suite for the pipeline library. >> >> It would be great to run it automatically as part of the CI testing.

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-15 Thread Ferruh Yigit
On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote: > When rte_log.h was moved to a new directory, the include path was not > updated for the generated C code produced by the pipeline library, > which results in build failure for this code. > > Fixes: 09ce41310930 ("log: separate logging functions ou

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-15 Thread Ferruh Yigit
Aaron >> Conole ; Richardson, Bruce >> >> Subject: Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h >> >> On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote: >>> When rte_log.h was moved to a new directory, the include path was not >>> updated f

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Patrick Robb
On Wed, Feb 14, 2024 at 3:00 PM Dumitrescu, Cristian < cristian.dumitre...@intel.com> wrote: > > > [Cristian] > Yes, you are right, we do have a DTS test suite for the pipeline library. > > It would be great to run it automatically as part of the CI testing. Just > a word of caution though: I am n

RE: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Dumitrescu, Cristian
Hi Patrick, See my comment below under your reply. From: Patrick Robb Sent: Wednesday, February 14, 2024 7:32 PM To: Aaron Conole Cc: Ferruh Yigit ; Dumitrescu, Cristian ; dev@dpdk.org; sta...@dpdk.org; Marchand, David ; Richardson, Bruce Subject: Re: [PATCH V2] examples/pipeline: fix

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Patrick Robb
Hi Aaron/Cristian, On Wed, Feb 14, 2024 at 11:25 AM Aaron Conole wrote: > Ferruh Yigit writes: > > > On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote: > >> When rte_log.h was moved to a new directory, the include path was not > >> updated for the generated C code produced by the pipeline library

RE: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Dumitrescu, Cristian
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, February 14, 2024 11:22 AM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: sta...@dpdk.org; Marchand, David ; Aaron > Conole ; Richardson, Bruce > > Subject: Re: [PATCH V2] examples/pipeli

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Aaron Conole
Ferruh Yigit writes: > On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote: >> When rte_log.h was moved to a new directory, the include path was not >> updated for the generated C code produced by the pipeline library, >> which results in build failure for this code. >> >> Fixes: 09ce41310930 ("log:

Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-14 Thread Ferruh Yigit
On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote: > When rte_log.h was moved to a new directory, the include path was not > updated for the generated C code produced by the pipeline library, > which results in build failure for this code. > > Fixes: 09ce41310930 ("log: separate logging functions ou

[PATCH V2] examples/pipeline: fix include path for rte_log.h

2024-02-13 Thread Cristian Dumitrescu
When rte_log.h was moved to a new directory, the include path was not updated for the generated C code produced by the pipeline library, which results in build failure for this code. Fixes: 09ce41310930 ("log: separate logging functions out of EAL") Cc: sta...@dpdk.org Signed-off-by: Cristian Dum