On Fri, Apr 26, 2024 at 8:06 PM Jeremy Spewock wrote:
>
> Apologies for being so late on the discussion, but just a few of my
> thoughts:
>
> * I think using something like overloading even though it is new to
> python is completely fine because this new python version is a
> dependency of the DT
Apologies for being so late on the discussion, but just a few of my
thoughts:
* I think using something like overloading even though it is new to
python is completely fine because this new python version is a
dependency of the DTS runner. The DTS runner can have bleeding-edge
requirements because
On 11/04/2024 13:13, Juraj Linkeš wrote:
The changes we discuss below don't seem that big. What do you think,
do we just add another patch to the series?
Sure thing, I can take this and add it to v2.
I thought about this a bit as well, it's a good approach. The current
design is top-down, a
On Thu, Apr 11, 2024 at 1:47 PM Luca Vizzarro wrote:
>
> On 11/04/2024 11:30, Juraj Linkeš wrote:
> > I've been thinking about these interactive shell constructors for some
> > time and I think the factory pattern is not well suitable for this.
> > Factories work well with classes with the same AP
On 11/04/2024 11:30, Juraj Linkeš wrote:
I've been thinking about these interactive shell constructors for some
time and I think the factory pattern is not well suitable for this.
Factories work well with classes with the same API (i.e.
implementations of abstract classes that don't add anything
I overlooked this reply initially.
On Wed, Apr 10, 2024 at 1:35 PM Luca Vizzarro wrote:
>
> On 10/04/2024 08:41, Juraj Linkeš wrote:
> >>
> >>> @@ -723,7 +731,13 @@ def _start_application(self, get_privileged_command:
> >>> Callable[[str], str] | None
> >>> if self._app_args.app_param
On 10/04/2024 08:50, Juraj Linkeš wrote:
On Tue, Mar 26, 2024 at 8:04 PM Luca Vizzarro wrote:
This commit provides a state container for TestPmdShell. It currently
only indicates whether the packet forwarding has started
or not, and the number of ports which were given to the shell.
A remin
On 10/04/2024 08:41, Juraj Linkeš wrote:
@@ -723,7 +731,13 @@ def _start_application(self, get_privileged_command:
Callable[[str], str] | None
if self._app_args.app_params is None:
self._app_args.app_params = TestPmdParameters()
-self.number_of_ports = len(self
On Tue, Mar 26, 2024 at 8:04 PM Luca Vizzarro wrote:
>
> This commit provides a state container for TestPmdShell. It currently
> only indicates whether the packet forwarding has started
> or not, and the number of ports which were given to the shell.
>
A reminder, the commit message should explai
On Thu, Mar 28, 2024 at 5:49 PM Jeremy Spewock wrote:
>
> On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote:
> >
> > This commit provides a state container for TestPmdShell. It currently
> > only indicates whether the packet forwarding has started
> > or not, and the number of ports which were
On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote:
>
> This commit provides a state container for TestPmdShell. It currently
> only indicates whether the packet forwarding has started
> or not, and the number of ports which were given to the shell.
>
> This also fixes the behaviour of `wait_link
This commit provides a state container for TestPmdShell. It currently
only indicates whether the packet forwarding has started
or not, and the number of ports which were given to the shell.
This also fixes the behaviour of `wait_link_status_up` to use the
command timeout as inherited from Interact
12 matches
Mail list logo
