Re: [PATCH 5/6] dts: add statefulness to InteractiveShell

2024-04-29 Thread Jeremy Spewock
On Wed, Apr 10, 2024 at 9:36 AM Juraj Linkeš wrote: > > On Wed, Apr 10, 2024 at 1:27 PM Luca Vizzarro wrote: > > > > On 10/04/2024 07:53, Juraj Linkeš wrote: > > > I have a general question. What are these changes for? Do you > > > anticipate us needing this in the future? Wouldn't it be better t

Re: [PATCH 5/6] dts: add statefulness to InteractiveShell

2024-04-12 Thread Juraj Linkeš
On Wed, Apr 10, 2024 at 4:07 PM Luca Vizzarro wrote: > > On 10/04/2024 14:35, Juraj Linkeš wrote: > > We should also consider that this would introduce a difference in API > > between the interactive and non-interactive sessions. Do we want to do > > this there as well? > > Could definitely add it

Re: [PATCH 5/6] dts: add statefulness to InteractiveShell

2024-04-10 Thread Luca Vizzarro
On 10/04/2024 14:35, Juraj Linkeš wrote: We should also consider that this would introduce a difference in API between the interactive and non-interactive sessions. Do we want to do this there as well? Could definitely add it there as well. You are referring to RemoteSession I presume, right?

Re: [PATCH 5/6] dts: add statefulness to InteractiveShell

2024-04-10 Thread Juraj Linkeš
On Wed, Apr 10, 2024 at 1:27 PM Luca Vizzarro wrote: > > On 10/04/2024 07:53, Juraj Linkeš wrote: > > I have a general question. What are these changes for? Do you > > anticipate us needing this in the future? Wouldn't it be better to add > > it only when we need it? > > It's been sometime since w

Re: [PATCH 5/6] dts: add statefulness to InteractiveShell

2024-04-10 Thread Luca Vizzarro
On 10/04/2024 07:53, Juraj Linkeš wrote: I have a general question. What are these changes for? Do you anticipate us needing this in the future? Wouldn't it be better to add it only when we need it? It's been sometime since we raised this task internally. This patch and the next one arise from

Re: [PATCH 5/6] dts: add statefulness to InteractiveShell

2024-04-09 Thread Juraj Linkeš
I have a general question. What are these changes for? Do you anticipate us needing this in the future? Wouldn't it be better to add it only when we need it? On Thu, Mar 28, 2024 at 5:48 PM Jeremy Spewock wrote: > > On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote: > > > diff --git a/dts/fra

Re: [PATCH 5/6] dts: add statefulness to InteractiveShell

2024-03-28 Thread Jeremy Spewock
On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro wrote: > diff --git a/dts/framework/remote_session/interactive_shell.py > b/dts/framework/remote_session/interactive_shell.py > index a2c7b30d9f..5d80061e8d 100644 > --- a/dts/framework/remote_session/interactive_shell.py > +++ b/dts/framework/remote

[PATCH 5/6] dts: add statefulness to InteractiveShell

2024-03-26 Thread Luca Vizzarro
The InteractiveShell class can be started in privileged mode, but this is not saved for reference to the tests developer. Moreover, originally a command timeout could only be set at initialisation, this can now be amended and reset back as needed. Signed-off-by: Luca Vizzarro Reviewed-by: Jack Bo