RE: [PATCH 4/4] mempool: use lcore API to check if lcore ID is valid

2023-03-10 Thread Konstantin Ananyev
> > > > > > > > > > > > > > Use lcore API to check if the lcore ID is valid. The runtime check > > > does not add much value. > > > > From my perspective it adds a perfect value: > > Only threads with valid lcore id have their own default mempool cache. > The threads would call 'rte_lcore_id()

RE: [PATCH 4/4] mempool: use lcore API to check if lcore ID is valid

2023-03-09 Thread Honnappa Nagarahalli
> > > > > > > Use lcore API to check if the lcore ID is valid. The runtime check > > does not add much value. > > From my perspective it adds a perfect value: > Only threads with valid lcore id have their own default mempool cache. The threads would call 'rte_lcore_id()' to return their lcore_

RE: [PATCH 4/4] mempool: use lcore API to check if lcore ID is valid

2023-03-09 Thread Konstantin Ananyev
> > Use lcore API to check if the lcore ID is valid. The runtime > check does not add much value. >From my perspective it adds a perfect value: Only threads with valid lcore id have their own default mempool cache. > Hence use assert to validate > the lcore ID. Wonder why? What's wrong for t

[PATCH 4/4] mempool: use lcore API to check if lcore ID is valid

2023-03-08 Thread Honnappa Nagarahalli
Use lcore API to check if the lcore ID is valid. The runtime check does not add much value. Hence use assert to validate the lcore ID. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Wathsala Vithanage Reviewed-by: Ruifeng Wang --- lib/mempool/rte_mempool.h | 5 ++--- 1 file changed, 2 insert