Re: [PATCH 3/5] dts: use Pydantic in the configuration

2024-10-29 Thread Luca Vizzarro
Likewise, thank you Juraj for the comments. Most if not all suggestions have been applied in the new versions. On 17/09/2024 12:13, Juraj Linkeš wrote: - the config schema is no longer used for validation but kept as an    alternative format for the developer If it's not used, we should remov

Re: [PATCH 3/5] dts: use Pydantic in the configuration

2024-10-29 Thread Luca Vizzarro
On 30/09/2024 22:45, Dean Marx wrote: -@dataclass(slots=True, frozen=True) +@dataclass(slots=True, frozen=True, kw_only=True, config=ConfigDict(extra="forbid")) Up to you but I think it might be worth specifying what some of these extra pydantic args are for if we're going to keep

Re: [PATCH 3/5] dts: use Pydantic in the configuration

2024-10-29 Thread Luca Vizzarro
On 30/09/2024 18:56, Nicholas Pratte wrote: +the YAML test run configuration file and validates it against the :class:`Configuration` Pydantic +dataclass model. The Pydantic model is also available as Out of curiosity, what is the reason for maintaining use of dataclasses here as opposed to cr

Re: [PATCH 3/5] dts: use Pydantic in the configuration

2024-09-30 Thread Dean Marx
On Thu, Aug 22, 2024 at 12:40 PM Luca Vizzarro wrote: > This change brings in Pydantic in place of Warlock. Pydantic offers > a built-in model validation system in the classes, which allows for > a more resilient and simpler code. As a consequence of this change: > > - most validation is now buil

Re: [PATCH 3/5] dts: use Pydantic in the configuration

2024-09-30 Thread Nicholas Pratte
Hi Luca! See my comments below, thanks! On Thu, Aug 22, 2024 at 12:40 PM Luca Vizzarro wrote: > > This change brings in Pydantic in place of Warlock. Pydantic offers > a built-in model validation system in the classes, which allows for > a more resilient and simpler code. As a consequence of this

Re: [PATCH 3/5] dts: use Pydantic in the configuration

2024-09-17 Thread Juraj Linkeš
On 22. 8. 2024 18:39, Luca Vizzarro wrote: This change brings in Pydantic in place of Warlock. Pydantic offers a built-in model validation system in the classes, which allows for a more resilient and simpler code. As a consequence of this change: - most validation is now built-in - further va

[PATCH 3/5] dts: use Pydantic in the configuration

2024-08-22 Thread Luca Vizzarro
This change brings in Pydantic in place of Warlock. Pydantic offers a built-in model validation system in the classes, which allows for a more resilient and simpler code. As a consequence of this change: - most validation is now built-in - further validation is added to verify: - cross referenci