Re: [PATCH 3/5] common/nfp: fix integer handling issues

2023-11-22 Thread Thomas Monjalon
23/11/2023 02:23, Chaoyong He: > > 15/11/2023 04:23, Chaoyong He: > > > CI found integer handling issues, overflow before widen. > > > > > > Coverity issue: 405351 > > > Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") > > > Cc: sta...@dpdk.org > > [...] > > > - enabled_queues |= (1 <<

RE: [PATCH 3/5] common/nfp: fix integer handling issues

2023-11-22 Thread Chaoyong He
> 15/11/2023 04:23, Chaoyong He: > > CI found integer handling issues, overflow before widen. > > > > Coverity issue: 405351 > > Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") > > Cc: sta...@dpdk.org > [...] > > - enabled_queues |= (1 << i); > > + enabled_queues |= (1ULL <

Re: [PATCH 3/5] common/nfp: fix integer handling issues

2023-11-22 Thread Thomas Monjalon
15/11/2023 04:23, Chaoyong He: > CI found integer handling issues, overflow before widen. > > Coverity issue: 405351 > Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") > Cc: sta...@dpdk.org [...] > - enabled_queues |= (1 << i); > + enabled_queues |= (1ULL << i); That's

[PATCH 3/5] common/nfp: fix integer handling issues

2023-11-14 Thread Chaoyong He
CI found integer handling issues, overflow before widen. Coverity issue: 405351 Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common.c | 4 ++-- 1 file changed, 2 inse