Re: [PATCH 3/3] eal/linux: Check hugepage access permissions

2025-05-07 Thread Jake Freeland
On Wed May 7, 2025 at 3:52 AM CDT, Stephen Hemminger wrote: > Please don't split message a across multiple lines. > Open and access are not the same in all security checks, so not a great > idea. What do you mean by this? In this case, access() is just verifying that we can read and write to the h

Re: [PATCH 3/3] eal/linux: Check hugepage access permissions

2025-05-07 Thread Stephen Hemminger
Please don't split message a across multiple lines. Open and access are not the same in all security checks, so not a great idea. Some analyzer tools may flag as time of check, time of use issue. On Wed, May 7, 2025, 02:50 Jake Freeland wrote: > Currently, hugepage mountpoints will be used irres

[PATCH 3/3] eal/linux: Check hugepage access permissions

2025-05-06 Thread Jake Freeland
Currently, hugepage mountpoints will be used irrespective of permissions, leading to potential EACCES errors during memory allocation. Fix this by not using a mountpoint if we do not have read/write permissions on it. Signed-off-by: Jake Freeland --- lib/eal/linux/eal_hugepage_info.c | 6 ++