RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration

2022-01-13 Thread Ananyev, Konstantin
> > > > > > > Another question - if we have reassembly_conf_set() would it make > > sense > > > to > > > > > > > have also reassembly_conf_get? > > > > > > > So user can retrieve current ip_reassembly config values? > > > > > > > > > > > > > The set/supported values can be retrieved using rte_et

RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration

2022-01-13 Thread Akhil Goyal
Hi Konstantin, > > > > > > Another question - if we have reassembly_conf_set() would it make > sense > > to > > > > > > have also reassembly_conf_get? > > > > > > So user can retrieve current ip_reassembly config values? > > > > > > > > > > > The set/supported values can be retrieved using rte_eth

RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration

2022-01-12 Thread Akhil Goyal
> > > > > Another question - if we have reassembly_conf_set() would it make > > > > > sense > to > > > > > have also reassembly_conf_get? > > > > > So user can retrieve current ip_reassembly config values? > > > > > > > > > The set/supported values can be retrieved using rte_eth_dev_info :: > > >

RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration

2022-01-12 Thread Ananyev, Konstantin
> > > > Another question - if we have reassembly_conf_set() would it make sense > > > > to > > > > have also reassembly_conf_get? > > > > So user can retrieve current ip_reassembly config values? > > > > > > > The set/supported values can be retrieved using rte_eth_dev_info :: > > reass_capa >

RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration

2022-01-12 Thread Akhil Goyal
> > > Another question - if we have reassembly_conf_set() would it make sense to > > > have also reassembly_conf_get? > > > So user can retrieve current ip_reassembly config values? > > > > > The set/supported values can be retrieved using rte_eth_dev_info :: > reass_capa > > Hmm, I thought rte_et

RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration

2022-01-12 Thread Ananyev, Konstantin
> > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > > > index d9a03f12f9..ecc6c1fe37 100644 > > > --- a/lib/ethdev/rte_ethdev.c > > > +++ b/lib/ethdev/rte_ethdev.c > > > @@ -6473,6 +6473,36 @@ rte_eth_rx_metadata_negotiate(uint16_t port_id, > > uint64_t *features) > > >

RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration

2022-01-11 Thread Akhil Goyal
> > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > > index d9a03f12f9..ecc6c1fe37 100644 > > --- a/lib/ethdev/rte_ethdev.c > > +++ b/lib/ethdev/rte_ethdev.c > > @@ -6473,6 +6473,36 @@ rte_eth_rx_metadata_negotiate(uint16_t port_id, > uint64_t *features) > >(*de

RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration

2022-01-11 Thread Ananyev, Konstantin
> A new ethernet device op is added to give application control over > the IP reassembly configuration. This operation is an optional > call from the application, default values are set by PMD and > exposed via rte_eth_dev_info. > Application should always first retreive the capabilities from >

[PATCH 2/8] ethdev: add dev op for IP reassembly configuration

2022-01-03 Thread Akhil Goyal
A new ethernet device op is added to give application control over the IP reassembly configuration. This operation is an optional call from the application, default values are set by PMD and exposed via rte_eth_dev_info. Application should always first retreive the capabilities from rte_eth_dev_inf