RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-06 Thread Konstantin Ananyev
fengchengwen > >>> ; Konstantin Ananyev > >>> ; Honnappa > >>> Nagarahalli ; Stephen Hemminger > >>> ; > >>> Ruifeng Wang ; Ajit Khaparde > >>> (ajit.khapa...@broadcom.com) > >>> > >>> Subject: Re: [PA

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-06 Thread Ferruh Yigit
Ananyev >>> ; Honnappa >>> Nagarahalli ; Stephen Hemminger >>> ; >>> Ruifeng Wang ; Ajit Khaparde >>> (ajit.khapa...@broadcom.com) >>> >>> Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup >>

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-06 Thread Ajit Khaparde
; > ; Konstantin Ananyev > > > ; Honnappa > > > Nagarahalli ; Stephen Hemminger > > > ; > > > Ruifeng Wang ; Ajit Khaparde > > > (ajit.khapa...@broadcom.com) > > > > > > Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-pat

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-06 Thread Konstantin Ananyev
t; ; > > Ruifeng Wang ; Ajit Khaparde > > (ajit.khapa...@broadcom.com) > > > > Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup > > > > On 2/26/2023 5:22 PM, Konstantin Ananyev wrote: > > > > > >>>>>>>&

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-05 Thread Ruifeng Wang
> (ajit.khapa...@broadcom.com) > > Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup > > On 2/26/2023 5:22 PM, Konstantin Ananyev wrote: > > > >>>>>>>>>>> If ethdev enqueue or dequeue function is called during > >>

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-05 Thread fengchengwen
On 2023/3/4 1:19, Ferruh Yigit wrote: > On 2/26/2023 5:22 PM, Konstantin Ananyev wrote: >> If ethdev enqueue or dequeue function is called during eth_dev_fp_ops_setup(), it may get pre-empted after setting the function pointers, but before setting the pointer

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-03 Thread Ferruh Yigit
On 2/26/2023 5:22 PM, Konstantin Ananyev wrote: > >>> If ethdev enqueue or dequeue function is called during >>> eth_dev_fp_ops_setup(), it may get pre-empted after setting the >>> function pointers, but before setting the pointer to port data. >>> In this case the

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-03-03 Thread Ferruh Yigit
On 2/20/2023 6:08 AM, Ashok Kaladi wrote: > If ethdev enqueue or dequeue function is called during > eth_dev_fp_ops_setup(), it may get pre-empted after setting > the function pointers, but before setting the pointer to port data. > In this case the newly registered enqueue/dequeue function will us

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-28 Thread Honnappa Nagarahalli
.com; > tho...@monjalon.net; dev@dpdk.org; s.v.naga.haris...@intel.com; > erik.g.carri...@intel.com; abhinandan.guj...@intel.com; sta...@dpdk.org; nd > > Subject: RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup > > > > > >>

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-27 Thread Konstantin Ananyev
> > > > > >>> > >>> BTW,  I don't see any implementation for RTE_ETH_EVENT_ERR_RECOVERING > >>> within > >>> either testpmd or any other example apps. > >>> Am I missing something? > >> > >> Currently it just promote the event. > > > > > > Ok, can I suggest then to add a proper usage for into in

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-26 Thread fengchengwen
On 2023/2/27 1:22, Konstantin Ananyev wrote: > >>> If ethdev enqueue or dequeue function is called during >>> eth_dev_fp_ops_setup(), it may get pre-empted after setting the >>> function pointers, but before setting the pointer to port data. >>> In this case the new

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-26 Thread Konstantin Ananyev
If ethdev enqueue or dequeue function is called during eth_dev_fp_ops_setup(), it may get pre-empted after setting the function pointers, but before setting the pointer to port data. In this case the newly registered enqueue/dequeue function will use dummy port data and end up in seg fault. Th

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-24 Thread fengchengwen
On 2023/2/23 21:31, Konstantin Ananyev wrote: > > > If ethdev enqueue or dequeue function is called during > eth_dev_fp_ops_setup(), it may get pre-empted after setting the > function pointers, but before setting the pointer to port data. > In this case the newly r

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-23 Thread Konstantin Ananyev
> >>> If ethdev enqueue or dequeue function is called during > >>> eth_dev_fp_ops_setup(), it may get pre-empted after setting the > >>> function pointers, but before setting the pointer to port data. > >>> In this case the newly registered enqueue/dequeue function will > >>>

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-23 Thread fengchengwen
On 2023/2/23 12:40, Honnappa Nagarahalli wrote: > > >> >> On 2023/2/20 14:08, Ashok Kaladi wrote: >>> If ethdev enqueue or dequeue function is called during >>> eth_dev_fp_ops_setup(), it may get pre-empted after setting the >>> function pointers, but before setting the pointe

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Honnappa Nagarahalli
.naga.haris...@intel.com; > erik.g.carri...@intel.com; abhinandan.guj...@intel.com; sta...@dpdk.org; nd > > Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup > > On Wed, 22 Feb 2023 22:48:25 + > Honnappa Nagarahalli wrote: > > > > ---

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Honnappa Nagarahalli
> > >>> > > >>> On 2023/2/20 14:08, Ashok Kaladi wrote: > > If ethdev enqueue or dequeue function is called during > > eth_dev_fp_ops_setup(), it may get pre-empted after setting the > > function pointers, but before setting the pointer to port data. > > In this case the newly

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Stephen Hemminger
Kaladi ; jer...@marvell.com; > > tho...@monjalon.net; Honnappa Nagarahalli > > ; dev@dpdk.org; > > s.v.naga.haris...@intel.com; erik.g.carri...@intel.com; > > abhinandan.guj...@intel.com; sta...@dpdk.org; nd > > Subject: RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Honnappa Nagarahalli
s.v.naga.haris...@intel.com; erik.g.carri...@intel.com; > abhinandan.guj...@intel.com; sta...@dpdk.org; nd > Subject: RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup > > > > > -Original Message- > > From: fengchengwen > > Sent: Wednesday, F

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Konstantin Ananyev
tel.com; > erik.g.carri...@intel.com; > abhinandan.guj...@intel.com; sta...@dpdk.org; nd > Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup > > On 2023/2/22 1:00, Stephen Hemminger wrote: > > On Tue, 21 Feb 2023 07:24:19 + > > Ruifeng Wang wro

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-22 Thread Ruifeng Wang
...@intel.com; erik.g.carri...@intel.com; > abhinandan.guj...@intel.com; > sta...@dpdk.org; nd > Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup > > On 2023/2/22 1:00, Stephen Hemminger wrote: > > On Tue, 21 Feb 2023 07:24:19 + > > Ruifeng Wang

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-21 Thread fengchengwen
>>> tho...@monjalon.net >>> Cc: dev@dpdk.org; s.v.naga.haris...@intel.com; erik.g.carri...@intel.com; >>> abhinandan.guj...@intel.com; sta...@dpdk.org; Ruifeng Wang >>> >>> Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup >&

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-21 Thread Stephen Hemminger
aga.haris...@intel.com; erik.g.carri...@intel.com; > > abhinandan.guj...@intel.com; sta...@dpdk.org; Ruifeng Wang > > > > Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup > > > > On 2023/2/20 14:08, Ashok Kaladi wrote: > > > If ethdev enqueu

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-20 Thread Ruifeng Wang
pdk.org; Ruifeng Wang > > Subject: Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup > > On 2023/2/20 14:08, Ashok Kaladi wrote: > > If ethdev enqueue or dequeue function is called during > > eth_dev_fp_ops_setup(), it may get pre-empted after setting the

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-20 Thread Konstantin Ananyev
> If ethdev enqueue or dequeue function is called during > eth_dev_fp_ops_setup(), it may get pre-empted after setting > the function pointers, but before setting the pointer to port data. > In this case the newly registered enqueue/dequeue function will use > dummy port data and end up in seg f

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-19 Thread fengchengwen
Sorry resend, because forget one line. On 2023/2/20 14:08, Ashok Kaladi wrote: > If ethdev enqueue or dequeue function is called during > eth_dev_fp_ops_setup(), it may get pre-empted after setting > the function pointers, but before setting the pointer to port data. > In this case the newly regis

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-19 Thread fengchengwen
On 2023/2/20 14:08, Ashok Kaladi wrote: > If ethdev enqueue or dequeue function is called during > eth_dev_fp_ops_setup(), it may get pre-empted after setting > the function pointers, but before setting the pointer to port data. > In this case the newly registered enqueue/dequeue function will use

[PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-19 Thread Ashok Kaladi
If ethdev enqueue or dequeue function is called during eth_dev_fp_ops_setup(), it may get pre-empted after setting the function pointers, but before setting the pointer to port data. In this case the newly registered enqueue/dequeue function will use dummy port data and end up in seg fault. This p