Re: [PATCH 2/2] app/testpmd: fix stack overflow for EEPROM display

2022-02-03 Thread Ferruh Yigit
On 2/2/2022 10:00 AM, Singh, Aman Deep wrote: Hi Steve The patch looks ok to me. On 1/20/2022 8:29 AM, Steve Yang wrote: When the size of EEPROM exceeds the default thread stack size(8MB), e.g.: 10Mb size, it will be cashed with stack overflow. Just spelling: 10Mb/10MB, cashed/crashed Can even

Re: [PATCH 2/2] app/testpmd: fix stack overflow for EEPROM display

2022-02-02 Thread Singh, Aman Deep
Hi Steve The patch looks ok to me. On 1/20/2022 8:29 AM, Steve Yang wrote: When the size of EEPROM exceeds the default thread stack size(8MB), e.g.: 10Mb size, it will be cashed with stack overflow. Just spelling: 10Mb/10MB, cashed/crashed Can even rephrase, like: it will crash due to stack ove

[PATCH 2/2] app/testpmd: fix stack overflow for EEPROM display

2022-01-19 Thread Steve Yang
When the size of EEPROM exceeds the default thread stack size(8MB), e.g.: 10Mb size, it will be cashed with stack overflow. Allocate the data of EPPROM information on the heap. Fixes: 6b67721dee2a ("app/testpmd: add EEPROM command") Signed-off-by: Steve Yang --- app/test-pmd/config.c | 22