RE: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs

2022-04-28 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Thursday, 28 April 2022 15.39 > > On 2022/4/25 18:16, Morten Brørup wrote: > >> From: fengchengwen [mailto:fengcheng...@huawei.com] > >> Sent: Sunday, 24 April 2022 05.45 > >> > >> The root cause is: when the xstats is NULL and n less t

RE: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs

2022-04-25 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Sunday, 24 April 2022 05.45 > > The root cause is: when the xstats is NULL and n less than required > number of > elements is zero, the return value of rte_eth_xstats_get is ambiguous > from > rte_ethdev.h's declaration. > > But the im

Re: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs

2022-04-20 Thread Andrew Rybchenko
On 4/16/22 04:38, Stephen Hemminger wrote: On Sat, 16 Apr 2022 09:07:45 +0800 Chengwen Feng wrote: Currently the telemetry xstats uses rte_eth_xstats_get() to retrieve the number of elements. But the value to be returned when the parameter 'xstats' is NULL is not specified, some PMDs (eg. hns3

Re: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs

2022-04-15 Thread Stephen Hemminger
On Sat, 16 Apr 2022 09:07:45 +0800 Chengwen Feng wrote: > Currently the telemetry xstats uses rte_eth_xstats_get() to retrieve > the number of elements. But the value to be returned when the parameter > 'xstats' is NULL is not specified, some PMDs (eg. hns3/ipn3ke/mvpp2/ > axgbe) return zero whil