Re: [PATCH 1/2] vhost: keep a reference to virtqueue index

On Fri, Jul 22, 2022 at 3:54 PM David Marchand wrote: > @@ -607,32 +594,20 @@ init_vring_queue(struct virtio_net *dev, uint32_t > vring_idx) > #endif > vq->numa_node = numa_node; > > - vhost_user_iotlb_init(dev, vring_idx); > + vhost_user_iotlb_init(dev, vq); Erm, it won't f

Re: [PATCH 1/2] vhost: keep a reference to virtqueue index

On Fri, Jul 22, 2022 at 3:54 PM David Marchand wrote: > > Having a back reference to the index of the vq in the dev->virtqueue[] > array makes it possible to unify the internal API with only passing dev > and vq. > It also allows displaying the vq index in log messages. Fwiw, this conflicts with

[PATCH 1/2] vhost: keep a reference to virtqueue index

Having a back reference to the index of the vq in the dev->virtqueue[] array makes it possible to unify the internal API with only passing dev and vq. It also allows displaying the vq index in log messages. Remove virtqueue index checks were unneeded (like in static helpers called from a loop on a